update: bring back borders around settings screen cards #11160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores the visual borders around cards displayed in the settings screens by removing CSS rules that were previously hiding box-shadows and borders. The changes are purely cosmetic and improve the visual hierarchy of the settings interface.
- Removes CSS rules that set
box-shadow: noneon various card components - Simplifies padding rules for card bodies
- Cleans up redundant styling rules
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| client/settings/settings-manager/style.scss | Removes CSS rules that were hiding box-shadows and borders on cards and removing padding from payment method list items |
| client/settings/payment-methods-list/style.scss | Simplifies the .wcpay-card-body padding rule by removing unnecessary :not() selector |
| client/settings/express-checkout/style.scss | Removes redundant padding rules for express checkout items that were already defined elsewhere |
| changelog/update-bring-back-card-borders | Adds changelog entry documenting the visual update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: -300 B (0%) Total Size: 877 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5522
Changes proposed in this Pull Request
Discussed here: pfHfG4-1JP-p2#comment-2274
Bringing back the "borders" around the cards displayed in the settings screens.
Changes are purely cosmetic.
After:
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge