Amount mismatch detection for already paid order #11165
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Contributor
|
Size Change: 0 B Total Size: 877 kB ℹ️ View Unchanged
|
…rder-reuses-the-same-payment
…rder-reuses-the-same-payment
rtio
changed the title
RadoslavGeorgiev
requested changes
Nov 28, 2025
Contributor
RadoslavGeorgiev
left a comment
RadoslavGeorgiev
left a comment
There was a problem hiding this comment.
Thanks for getting so far with this! Duplicate payments are generally a deep and scary area :D
I have a couple of relatively small comments, but the general direction seems correct to me. I have not tested this yet, but I am fairly certain that it will work. I'll test on Monday, once my comments have been addressed.
…rder-reuses-the-same-payment
…rder-reuses-the-same-payment
RadoslavGeorgiev
approved these changes
Dec 2, 2025
Contributor
RadoslavGeorgiev
left a comment
RadoslavGeorgiev
left a comment
There was a problem hiding this comment.
Thank you for addressing this! The fix is pretty clean and straight-forward, I like it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5519
Changes proposed in this Pull Request
includes/class-duplicate-payment-prevention-service.php:118. When duplicate payment prevention detected an already-paid order, it calledupdate_order_status_from_intent().check_payment_intent_attached_to_order_succeeded().Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge