Add Tracks to Place Order button #7854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +400 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
malithsen
requested review from
a team and
hsingyuc
and removed request for
a team
hsingyuc
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
@malithsen Thank you for working on this! I see the event logged when placing the order with WooPayments on both Blocks and shortcode checkout, and the code makes sense to me.
I want to note that wcpay_checkout_place_order_button_click logged twice each time.
But the function is only triggered once in the merchant, so maybe that's something wrong with tracks.
Ah good catch. Looks like the form is submitted twice when placing the order. Fixed with 52ba858 |
hsingyuc
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Record Tracks event when clicking the Place Order button when using WooPayments.
Testing instructions
wcpay_checkout_place_order_button_clickevent from your site.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge