Add active plugin list to compatibility service #7933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
…lude-active-plugins
…lude-active-plugins
Remove wrapper method
…lude-active-plugins
…lude-active-plugins
jessepearson
requested changes
Jan 9, 2024
jessepearson
approved these changes
Jan 9, 2024
|
@allie500 I think a test like this can be added: public function test_update_compatibility_data_active_plugins_false() {
// Arrange: Create the expected value to be passed to update_compatibility_data.
$expected = [
'woopayments_version' => WCPAY_VERSION_NUMBER,
'woocommerce_version' => WC_VERSION,
'active_plugins' => [],
];
$this->break_active_plugins_option();
// Arrange/Assert: Set the expectations for update_compatibility_data.
$this->mock_api_client
->expects( $this->once() )
->method( 'update_compatibility_data' )
->with( $expected );
// Act: Call the method we're testing.
$this->compatibility_service->update_compatibility_data();
$this->fix_active_plugins_option();
}
private function break_active_plugins_option() {
update_option( 'temp_active_plugins', get_option( 'active_plugins' ) );
delete_option( 'active_plugins' );
}
private function fix_active_plugins_option() {
update_option( 'active_plugins', get_option( 'temp_active_plugins' ) );
delete_option( 'temp_active_plugins' );
} |
Thanks for the suggestion. I've added the test in afdb9b7. |
jessepearson
approved these changes
Jan 11, 2024
allie500
deleted the
add/server-3942-compatibility-service-include-active-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Automattic/woocommerce-payments-server/issues/3942
Changes proposed in this Pull Request
This PR adds the merchant site's active plugin list to the compatibility service.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge