Consolidate gateways implementation - step II #7944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -241 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
timur27
force-pushed
the
cleanup/upe-gateways-II
branch
2 times, most recently
from
5971468 to
1255ed4
Compare
timur27
force-pushed
the
cleanup/upe-gateways-II
branch
from
1255ed4 to
0c1f238
Compare
timur27
force-pushed
the
cleanup/upe-gateways-II
branch
2 times, most recently
from
5105bfb to
9159e5d
Compare
timur27
force-pushed
the
cleanup/upe-gateways-II
branch
from
9159e5d to
d256f60
Compare
timur27
requested review from
a team,
mdmoore and
gpressutto5
and removed request for
a team and
mdmoore
gpressutto5
approved these changes
Dec 28, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the second step of #7782. The first part is covered by #7937.
Changes proposed in this Pull Request
#7937 merged the split UPE into the UPE gateway, leaving the merging of the UPE gateway into the gateway for this PR. Th main goal of this PR is to have the single gateway class for the WooPayments plugin.
While merging, some unused areas of code (e.g. non-used variables) were removed from the codebase as well.
Testing instructions
save payment methodcheckbox is displayed both on shortcode and blocks checkoutsave payment methodcheckbox is displayed)Ordersif the order is displayed correctlyThis PR touches main classes so it's hard to pin-point some explicit test cases. I expect plugin to either fail at some major stages (like e.g. opening the checkout page) or work correctly everywhere. Besides the above list of testing instructions, feel free to additionally check anything you might find worth checking after going through the code.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge