Merge split UPE tests with main gateway tests #7954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timur27
changed the title
timur27
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
timur27
force-pushed
the
merge/upe-non-upe-tests
branch
from
c31b65d to
4d9bbb6
Compare
added 8 commits
January 3, 2024 07:43
…d to test regressions
…ayment_intent_id param
timur27
force-pushed
the
merge/upe-non-upe-tests
branch
6 times, most recently
from
93adcd7 to
c4e521c
Compare
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
timur27
force-pushed
the
merge/upe-non-upe-tests
branch
3 times, most recently
from
d74f2ed to
236e05e
Compare
timur27
force-pushed
the
merge/upe-non-upe-tests
branch
from
0cd1b8c to
88e61d2
Compare
timur27
force-pushed
the
merge/upe-non-upe-tests
branch
2 times, most recently
from
35dce83 to
8dde4c2
Compare
timur27
requested review from
a team and
mdmoore
and removed request for
a team
|
|
mdmoore
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
This is a massive undertaking but it's really nice to see all of this consolidation! Thanks for working on it.
As we discussed, the E2E tests are failing on develop so it's hard to understand if the changes here are currently passing. But I can see they were passing in previous runs, so I think it's likely that the changes here aren't contributing to the failures on the latest runs. As you mentioned, you don't intend to merge this until the E2E tests are passing on develop.
The unit tests are passing and the changes seem solid from what I can see(there's a lot). I left a couple really small comments/text changes. I'll go ahead and approve as those changes aren't blockers to anything. Really nice work!
timur27
added
the
status: blocked
|
Blocked by failing the e2e test on |
added 3 commits
January 18, 2024 13:38
…into merge/upe-non-upe-tests
…into merge/upe-non-upe-tests
timur27
removed
the
status: blocked
Jinksi
pushed a commit
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Timur Karimov <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7953
Changes proposed in this Pull Request
This PR merges three unit test suites into one, making
test-class-wc-payment-gateway-wcpay.phpthe only test suite that covers everything. While combining, several improvements were made to the tests. The most significant one is we don't mock the unit under tests now.Additionally, this PR removes the duplicates from E2E tests. Previously, we had multiple test suites checking e.g. saving cards and each test suite was doing it under different setting e.g. UPE or legacy card. Since we streamlined them now, there's no need to have duplicated tests either.
Tests that, in my view, need further analysis to comprehend their outcomes are accompanied by my comments. These comments detail whether the test was removed, relocated to a file, or modified. If a test doesn't have a comment, this means it was simply moved to the main gateway test suite w/o any big modifications, but of course feel free to raise any questions you might have.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge