Add E2E tests for merchant on-boarding #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +60 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
bborman22
and removed request for
a team
rafaelzaleski
commented
Jan 12, 2024
| @@ -33,7 +33,7 @@ | |||
| "test:e2e-up": "./tests/e2e/env/up.sh", | |||
| "test:e2e-cleanup": "./tests/e2e/env/cleanup.sh", | |||
| "test:e2e-reset": "npm run test:e2e-down && npm run test:e2e-cleanup", | |||
| "test:e2e": "NODE_CONFIG_DIR='tests/e2e/config' wp-scripts test-e2e --config tests/e2e/config/jest.config.js", | |||
| "test:e2e": "NODE_CONFIG_DIR='tests/e2e/config' JEST_PUPPETEER_CONFIG='tests/e2e/config/jest-puppeteer-headless.config.js' wp-scripts test-e2e --config tests/e2e/config/jest.config.js", | |||
There was a problem hiding this comment.
Added to be able to work with iframes.
bborman22
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
I was able to run these new tests locally with success and I see that the tests are passing on the GH actions. I also worked through the new tests and they hit on the key pieces of the multicurrency onboarding flow and functionality.
We spoke a bit about the other failing shopper tests and the difficulty in running the tests in headed mode locally, and confirmed those are unrelated to this PR so approving.
LGTM!
achyuthajoy
requested changes
Jan 23, 2024
There was a problem hiding this comment.
@rafaelzaleski As discussed on slack, I've done a quick review of the changes inside .github directory and left a comment regarding screenshots directory change.
As the other changes are already reviewed and approved by your team, I haven't looked at those.
|
@achyuthajoy, I've re-added |
achyuthajoy
approved these changes
Jan 24, 2024
Jinksi
pushed a commit
that referenced
this pull request
Jan 30, 2024
Co-authored-by: Brian Borman <[email protected]> Co-authored-by: Achyuth Ajoy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7347
Changes proposed in this Pull Request
Test Suites:
Testing instructions
npm run test:e2e merchant-admin-multi-currency-on-boarding.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge