Fix missing transaction error when viewing orders placed in mismatched test mode #7972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +19 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Jinksi
commented
Jan 4, 2024
brucealdridge
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7967
Fixes #7076
Changes proposed in this Pull Request
This PR checks to see if the order and site test mode match before rendering the disputed order notice and subsequently fetching charge data.
This prevents the error
Error: No such charge: 'ch_abcde';from being returned by the server and theError retrieving transaction.snackbar from rendering.To ensure the notice continues to render for orders created prior to 6.9 (which added the
wcpay_modeorder meta #7651), the disputed order notice will always render if nowcpay_modeorder meta is defined.Tradeoffs of this approach:
Testing instructions
ej-wcpay-auswith a live-mode order here).develop, you will notice a network request error and aError retrieving transactionsnackbar./chargesnetwork request will not occur and there should not be an error snackbar.Disputed orders
4000000000000259.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge