Rerender Woopay Button on jQuery Events #7981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovo-h
requested review from
a team and
rafaelzaleski
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -3 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
rafaelzaleski
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
LGTM!
✅ Confirm: WooPay Button Does Not Re-render On trunk
✅ Test: WooPay Button Re-renders When Updating Cart Totals
✅ Regression Test: WooPay Button Navigates to Woopay
✅ Regression Test: WooPay Button Navigates to Woopay, Even After Re-render
✅ Confirm: Implemented Solution Matches Suggested Solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Changes proposed in this Pull Request
This PR adds jQuery listeners for the following events:
updated_cart_totalsandupdated_checkout.Previously, there were DOM element listeners (e.g.
document.body.addEventListener( ... )), but it seems thejQuery.trigger( ... )wasn't always calling thedispatchEvent(...).This was causing the issue where the WooPay button would not receive the event and, therefore, would not re-render the WooPay button.
Testing instructions
2395-gh-Automattic/woopay
Confirm: WooPay Button Does Not Re-render On
trunktrunkbranch.Update cartbutton.Test: WooPay Button Re-renders When Updating Cart Totals
2395-rerender-woopay-button-on-cart-updatebranch.Update cartbutton.Regression Test: WooPay Button Navigates to Woopay
2395-rerender-woopay-button-on-cart-updatebranch.Buy with WooPaybutton.Regression Test: WooPay Button Navigates to Woopay, Even After Re-render
2395-rerender-woopay-button-on-cart-updatebranch.Update cartbutton. Repeat this step twice.2398-gh-Automattic/woopay
Confirm: Implemented Solution Matches Suggested Solution
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge