-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility data when onboarding #7990
Add compatibility data when onboarding #7990
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
…g to be used outside of the class, but is not any more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the testing instructions and everything worked as expected. The code is clear and it's covered by unit tests.
Thanks for working on this one! LGTM 🚢
Fixes https://github.com/Automattic/woocommerce-payments-server/issues/4423
Changes proposed in this Pull Request
get_compatibility_data
method to get the compatibility data for any method in the class.wp_count_posts
toint
due to an error in unit tests.stylesheet
active_plugins
post_types_count
test_posts
get_mock_compatibility_data
add_stylesheet_filter
add_option_active_plugins_filter
remove_stylesheet_filters
remove_option_active_plugins_filters
set_up
ortear_down
methods where needed so they are automatically done with each test.get_mock_compatibility_data
method is set up to get default compatibility data, with the option to pass an array to allow for returning modified data.insert_test_posts
anddelete_test_posts
to accept arrays to modify the data, if needed.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge