-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility Service: Send the post type count #8000
Compatibility Service: Send the post type count #8000
Conversation
WIP unit test update
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I followed the testing instructions from the server PR and everything worked as expected. The changes look good to me and the code is covered by unit tests.
Thanks for working on this one! LGTM! 🚢
Fixes https://github.com/Automattic/woocommerce-payments-server/issues/3944
Changes proposed in this Pull Request
This PR adds an array of the counts of the public post types published posts. The array keys are the post types and the value is the count of published posts for that post type.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge