-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Dev/Sandbox Mode Choice Design #8002
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: -121 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
Hi @elizaan36! 👋 Would it be possible to get a review on the design for the updates to the first page of the onboarding flow to make sure it all looks okay? You should be able to test by spinning up a new JN site from this PR and starting an onboarding. Thanks! |
hey @dmallory42, I'm wondering why does this notice appear before the user has made a selection. ![]() I think this would be very confusing for the new user because they'll wonder if they did something wrong. In terms of the design, I proposed an update to this screen to give merchants some context before launching into the Jetpack connection flow. I shared this in a couple places but haven't heard any feedback. ![]() Would it make sense to take a step back and update this screen as part of the initiative to provide more context for Jetpack? There's also a timing consideration with moving the TOS copy. We need to create an issue to update the Woo Home task screen (in core and Woo Express). We're removing the incentive and TOS copy from the task, and not adding any marketing copy to replace it. ![]() I think we should time both updates so the Home task is a fast follow as double TOS copy may impact conversion. cc @vladolaru |
Hi @elizaan36! 👋
![]() This is unrelated to these changes, it was added in this issue: #6429 The context to it is that it will only appear if Dev Mode is activated on a plugin-wide level (usually this would either be by installing the Dev Tools plugin or adding a special constant to the
Apologies for crossed wires here - my understanding was that the design proposed in paJDYF-bGl-p2 was what we were going ahead with. I remember seeing your comment where you added an update to this screen but I didn't realise it was intended to supersede this design - I thought it was an ongoing discussion about future improvements to the flow as that would likely involve more changes such as replacing the Connect screen.
We can definitely do that if you'd like - my feeling is that this design is improving on what we had previously because it de-emphasises the sandbox option, but we can either proceed with what we have here and then increment on it, or take a step back and implement the newer design. Let me know how you want to proceed!
I think (but let me know if I misunderstood) that this has already been covered by @ismaeldcom's PR here: woocommerce/woocommerce#43365 |
@dmallory42 @elizaan36 In light of the many discussions and proposals ( paJDYF-bWH-p2 ) around improving our onboarding flows through running experiments, I've decided to unblock this issue as we have the Woo core ToS changes timings to consider. Setting up the two variations for the experiments will take time and we need to keep up with core on the ToS moving to the MOX (part of this issue). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this and accepting my suggestions 🙂
There are a couple of style differences between the design and the implementation, all of them related with spacing and sizes. But knowing that it is consistent with the previous design, and that we will iterate on this soon, I think it's okay to proceed.
I see this is already merged but I was coming here to say that it makes sense to move forward with the proposed changes as-is, since finalizing the more holistic flow / experiment will take more time. |
@vladolaru Is there an issue for the task list changes? |
Ah edit, I see that PR #43365 has already been merged as well. |
Co-authored-by: Vlad Olaru <[email protected]>
Fixes #7731
Changes proposed in this Pull Request
Screenshots
Should match the design as laid out here: paJDYF-bGl-p2
Note: I haven't removed the subheading on the design yet as I wanted to double check this first.
Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge