Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dev/Sandbox Mode Choice Design #8002

Merged
merged 9 commits into from
Jan 19, 2024

Conversation

dmallory42
Copy link
Contributor

Fixes #7731

Changes proposed in this Pull Request

  • Define new component, OnboardingCard to represent a card containing content on the onboarding flow.
  • Remove RadioCard component which is no longer used.
  • Update to match latest designs.

Screenshots

Screenshot 2024-01-10 at 11 53 19

Should match the design as laid out here: paJDYF-bGl-p2

Note: I haven't removed the subheading on the design yet as I wanted to double check this first.

Testing instructions

  • Disconnect or delete your previous account in the DB so WooPayments thinks there is no account connected.
  • Initiate a new onboarding flow.
  • Verify that the new design for the first page of the flow looks as expected.
  • Start the flow using the "live" option (if you have sandbox mode enabled it will still create a test account) and go through the flow and verify that you can create an account.
  • Start the flow using the sandbox option and verify you get redirected to the Stripe test KYC and you can create an account.

  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@dmallory42 dmallory42 requested a review from a team January 10, 2024 11:57
@botwoo
Copy link
Collaborator

botwoo commented Jan 10, 2024

Test the build

Option 1. Jetpack Beta

  • Install and activate Jetpack Beta.
  • Use this build by searching for PR number 8002 or branch name dev/7731-update-dev-mode-choice in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.


Build info:

  • Latest commit: 99ecc69
  • Build time: 2024-01-19 14:52:04 UTC

Note: the build is updated when a new commit is pushed to this PR.

@dmallory42 dmallory42 changed the title Dev/7731 update dev mode choice Update Dev Mode Choice Design Jan 10, 2024
@dmallory42 dmallory42 changed the title Update Dev Mode Choice Design Update Dev/Sandbox Mode Choice Design Jan 10, 2024
Copy link
Contributor

github-actions bot commented Jan 10, 2024

Size Change: -121 B (0%)

Total Size: 1.27 MB

Filename Size Change
release/woocommerce-payments/dist/index-rtl.css 36.9 kB -50 B (0%)
release/woocommerce-payments/dist/index.css 36.9 kB -49 B (0%)
release/woocommerce-payments/dist/index.js 289 kB -22 B (0%)
ℹ️ View Unchanged
Filename Size
release/woocommerce-payments/assets/css/admin.css 1.06 kB
release/woocommerce-payments/assets/css/success.css 158 B
release/woocommerce-payments/dist/blocks-checkout-rtl.css 1.81 kB
release/woocommerce-payments/dist/blocks-checkout.css 1.81 kB
release/woocommerce-payments/dist/blocks-checkout.js 85.1 kB
release/woocommerce-payments/dist/checkout-rtl.css 318 B
release/woocommerce-payments/dist/checkout.css 319 B
release/woocommerce-payments/dist/checkout.js 37.2 kB
release/woocommerce-payments/dist/multi-currency-analytics.js 1.05 kB
release/woocommerce-payments/dist/multi-currency-rtl.css 3.4 kB
release/woocommerce-payments/dist/multi-currency-switcher-block.js 60.8 kB
release/woocommerce-payments/dist/multi-currency.css 3.4 kB
release/woocommerce-payments/dist/multi-currency.js 56 kB
release/woocommerce-payments/dist/order-rtl.css 676 B
release/woocommerce-payments/dist/order.css 679 B
release/woocommerce-payments/dist/order.js 42.3 kB
release/woocommerce-payments/dist/payment-gateways-rtl.css 1.31 kB
release/woocommerce-payments/dist/payment-gateways.css 1.31 kB
release/woocommerce-payments/dist/payment-gateways.js 39.6 kB
release/woocommerce-payments/dist/payment-request-rtl.css 153 B
release/woocommerce-payments/dist/payment-request.css 153 B
release/woocommerce-payments/dist/payment-request.js 13.5 kB
release/woocommerce-payments/dist/product-details.js 919 B
release/woocommerce-payments/dist/settings-rtl.css 10.3 kB
release/woocommerce-payments/dist/settings.css 10.3 kB
release/woocommerce-payments/dist/settings.js 234 kB
release/woocommerce-payments/dist/subscription-edit-page.js 669 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css 519 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal.css 519 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal.js 20.5 kB
release/woocommerce-payments/dist/subscription-product-onboarding-toast.js 710 B
release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css 117 B
release/woocommerce-payments/dist/subscriptions-empty-state.css 117 B
release/woocommerce-payments/dist/subscriptions-empty-state.js 19.6 kB
release/woocommerce-payments/dist/tos-rtl.css 230 B
release/woocommerce-payments/dist/tos.css 231 B
release/woocommerce-payments/dist/tos.js 22.1 kB
release/woocommerce-payments/dist/woopay-express-button-rtl.css 153 B
release/woocommerce-payments/dist/woopay-express-button.css 153 B
release/woocommerce-payments/dist/woopay-express-button.js 52.5 kB
release/woocommerce-payments/dist/woopay-rtl.css 4.18 kB
release/woocommerce-payments/dist/woopay.css 4.19 kB
release/woocommerce-payments/dist/woopay.js 72.1 kB
release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css 622 B
release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js 812 B
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js 2.43 kB
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js 1.01 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js 522 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js 581 B
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js 160 B
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css 2.37 kB
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js 13.5 kB
release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css 2.37 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css 1.03 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css 291 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css 403 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css 3.6 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css 299 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css 742 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css 572 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css 411 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js 544 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js 9.4 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js 6.8 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js 3.83 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js 544 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js 2.52 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js 22.1 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js 11.6 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js 1.29 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js 502 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js 355 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js 429 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js 1.38 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js 781 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js 1.1 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js 1.27 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css 392 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js 3.05 kB

compressed-size-action

@dmallory42
Copy link
Contributor Author

Hi @elizaan36! 👋 Would it be possible to get a review on the design for the updates to the first page of the onboarding flow to make sure it all looks okay? You should be able to test by spinning up a new JN site from this PR and starting an onboarding.

Thanks!

@elizaan36
Copy link

elizaan36 commented Jan 12, 2024

hey @dmallory42, I'm wondering why does this notice appear before the user has made a selection.

image

I think this would be very confusing for the new user because they'll wonder if they did something wrong.

In terms of the design, I proposed an update to this screen to give merchants some context before launching into the Jetpack connection flow. I shared this in a couple places but haven't heard any feedback.

Screenshot 2024-01-11 at 9 02 45 PM

Would it make sense to take a step back and update this screen as part of the initiative to provide more context for Jetpack?

There's also a timing consideration with moving the TOS copy. We need to create an issue to update the Woo Home task screen (in core and Woo Express). We're removing the incentive and TOS copy from the task, and not adding any marketing copy to replace it.

image

I think we should time both updates so the Home task is a fast follow as double TOS copy may impact conversion.

cc @vladolaru

@dmallory42
Copy link
Contributor Author

dmallory42 commented Jan 12, 2024

Hi @elizaan36! 👋

hey @dmallory42, I'm wondering why does this notice appear before the user has made a selection.
image

image

This is unrelated to these changes, it was added in this issue: #6429

The context to it is that it will only appear if Dev Mode is activated on a plugin-wide level (usually this would either be by installing the Dev Tools plugin or adding a special constant to the wp-config.php) - so this is something that would not be seen by 99% of users. The purpose is to warn that a test account will be created regardless of which option is selected - but as I mentioned, this is a pretty niche case that won't affect live accounts, only those who are testing the plugin like devs (Dev Tools is included when a JN site is spun up for testing).

In terms of the design, I proposed an update to this screen to give merchants some context before launching into the Jetpack connection flow. I shared this in a couple places but haven't heard any feedback.

Apologies for crossed wires here - my understanding was that the design proposed in paJDYF-bGl-p2 was what we were going ahead with. I remember seeing your comment where you added an update to this screen but I didn't realise it was intended to supersede this design - I thought it was an ongoing discussion about future improvements to the flow as that would likely involve more changes such as replacing the Connect screen.

Would it make sense to take a step back and update this screen as part of the initiative to provide more context for Jetpack?

We can definitely do that if you'd like - my feeling is that this design is improving on what we had previously because it de-emphasises the sandbox option, but we can either proceed with what we have here and then increment on it, or take a step back and implement the newer design. Let me know how you want to proceed!

There's also a timing consideration with moving the TOS copy. We need to create an issue to update the Woo Home task screen (in core and Woo Express). We're removing the incentive and TOS copy from the task, and not adding any marketing copy to replace it.

I think (but let me know if I misunderstood) that this has already been covered by @ismaeldcom's PR here: woocommerce/woocommerce#43365

@vladolaru
Copy link
Contributor

vladolaru commented Jan 19, 2024

@dmallory42 @elizaan36 In light of the many discussions and proposals ( paJDYF-bWH-p2 ) around improving our onboarding flows through running experiments, I've decided to unblock this issue as we have the Woo core ToS changes timings to consider.

Setting up the two variations for the experiments will take time and we need to keep up with core on the ToS moving to the MOX (part of this issue).

Copy link
Contributor

@ismaeldcom ismaeldcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this and accepting my suggestions 🙂

There are a couple of style differences between the design and the implementation, all of them related with spacing and sizes. But knowing that it is consistent with the previous design, and that we will iterate on this soon, I think it's okay to proceed.

@vladolaru vladolaru added this pull request to the merge queue Jan 19, 2024
Merged via the queue into develop with commit e375e8b Jan 19, 2024
24 of 26 checks passed
@vladolaru vladolaru deleted the dev/7731-update-dev-mode-choice branch January 19, 2024 15:34
@elizaan36
Copy link

I see this is already merged but I was coming here to say that it makes sense to move forward with the proposed changes as-is, since finalizing the more holistic flow / experiment will take more time.

@elizaan36
Copy link

we have the Woo core ToS changes timings to consider

@vladolaru Is there an issue for the task list changes?

@elizaan36
Copy link

Ah edit, I see that PR #43365 has already been merged as well.

Jinksi pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new onboarding mode selection screen should have a more prominent "live account" mode choice
5 participants