Revert "Displaying Clearpay instead of Afterpay for UK based stores" #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -601 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
frosso
approved these changes
Jan 17, 2024
|
I'm merging this to avoid further disruption from the account cache null issue - thanks for prompt review @frosso and @jessepearson thanks for opening the PR 🏅 @gpressutto5 I'll reopen #6425 so y'all can refine #7995 and get that fix back in time for code freeze. Apologies for disrupting that project, I'm prioritising robust dev flows as the account cache and ability to refresh it are critical for many folks developing on WooPayments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7995 ; that PR unintentionally breaks updating the account cache in WCPay Dev tools (a key developer flow):
This seems caused by initialisation order problems with Logger and WC_Payments classes.