-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix E2E shopper tests around 3DS and UPE settings #8123
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
03a3534
Fix E2E shopper tests around 3DS and UPE settings
bborman22 fe7c19f
Add changelog
bborman22 d1fed43
Merge branch 'develop' into fix/e2e-tests
bborman22 1541322
Add postcodes for UPE customers
bborman22 d5b5c9d
Merge branch 'develop' into fix/e2e-tests
achyuthajoy 9a2809b
Remove unnecessary card type from card authentication
bborman22 070096c
Merge remote-tracking branch 'origin/fix/e2e-tests' into fix/e2e-tests
bborman22 1522aee
Merge branch 'develop' into fix/e2e-tests
bborman22 ceb78d5
Merge branch 'develop' into fix/e2e-tests
bborman22 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: dev | ||
|
||
Fix for E2E shopper tests around 3DS and UPE settings |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,7 @@ | |
"addressfirstline": "Rue de l’Étuve, 1000", | ||
"addresssecondline": "billing-be", | ||
"city": "Bruxelles", | ||
"postcode": "1000", | ||
"phone": "123456789", | ||
"email": "[email protected]" | ||
}, | ||
|
@@ -95,6 +96,7 @@ | |
"addressfirstline": "Petuelring 130", | ||
"addresssecondline": "billing-de", | ||
"city": "München", | ||
"postcode": "80809", | ||
"state": "DE-BY", | ||
"phone": "123456789", | ||
"email": "[email protected]" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bborman22 I haven't checked Stripe test cards, if there are any specific ones which are triggering 3DS1 check, but AFAIK there is no code which would trigger 3DS1 check here.
For the context: So this might a dead code now. I did so in #8121 to trick linter, otherwise it would complain on unused
cardType
argument :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, I tested all the cards we have defined and none triggered the 3DS1 flow, so I removed card type for this function entirely as it doesn't seem we need to look for 3DS1 any more.