Add Payment Overview Widget data highlight components #8303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
dmallory42
requested changes
Mar 6, 2024
|
|
||
| const PaymentChangeFlow: React.FunctionComponent< { | ||
| change: number; | ||
| } > = ( { change } ): JSX.Element => { |
There was a problem hiding this comment.
Since both cases look pretty similar (only some minor class name changes), I wonder if we can just set some variables representing the class names which need to change based on if change < 0 to avoid having to write the markup twice. 🙂
There was a problem hiding this comment.
Thank you, @dmallory42! Indeed, that block could be enhanced to avoid duplicate markup. Improved with f9f641b.
| change={ 11 } | ||
| reportUrl="#" | ||
| tooltip={ __( | ||
| 'Fees includes fees on payments as well as dusputes.', |
There was a problem hiding this comment.
Typo: should read disputes.
Also maybe we should look again at this sentence (I'm not sure if the text has been reviewed yet so please ignore if that's already in progress), using the word 'fees' twice in this sentence may be confusing for merchants IMO.
There was a problem hiding this comment.
Thank you! The tooltips are temporary placeholders, as they have not been finalized yet.
oaratovskyi
reviewed
Mar 7, 2024
|
Handover details: pepjwh-Ok-p2#comment-931 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8196
Changes proposed in this Pull Request
This PR adds a four column widget to display charges, refunds, disputes, and fees data - based on the selected filters.
Demo:
Overview.Payments.WooCommerce.Payments.WooCommerce.-.6.March.2024.mp4
Testing instructions
Note
Since the Payment Overview Widget data hasn't been implemented yet, we're unable to perform manual testing on the component. Therefore, I've utilized test data for evaluation purposes.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge