Add missing tracks source for clicks on Fees tile link
#8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2024 13:23
… are distinguishable in tracks
+ move all tracksSource props to top so easier to check/confirm
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +3 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
haszari
commented
Jun 7, 2024
| isLoading={ isLoading } | ||
| /> | ||
| <PaymentDataTile | ||
| id="wcpay-payment-data-highlights__fees" | ||
| tracksSource="fees" |
There was a problem hiding this comment.
I didn't realise that this tile is not clickable like the others. So it doesn't really need a tracksSource. TBC
There was a problem hiding this comment.
Marking PR as blocked, discussing internally.
May back out of this PR since the main benefit is adding fees source, without that it's not a good idea to make the prop mandatory.
8 tasks
haszari
changed the title
source for clicks on Fees tile link
haszari
added
the
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8491
Changes proposed in this Pull Request
PaymentDataTiletracksSourceprop required.tracksSourceis closer to the id, easier to see which track source applies to which tile.Marking this PR as blocked since the fees tile doesn't need a tracks event. TBC.