Update/8581 replace intl tel input 2 #9155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -72.2 kB (-5%) ✅ Total Size: 1.26 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8581
Changes proposed in this Pull Request
PhoneNumberInputcomponent from@woocommerce/componentsinstead ofintl-tel-inputintl-tel-inputfrom the package.json dependencies, remove all references.PhoneNumberInputsince@woocommerce/components(window.wc.components) is not available in checkout. See details in this comment: Replaceintl-tel-inputcomponent with the WooCommerce PhoneNumberInput component #8581 (comment)watchPathIgnorePatternsto prevent errors when runningnpm run test:watchTesting instructions
Payment Settings
Onboard with a new Stripe account or use one that doesn't have a support phone number set
Go to WP Admin -> Payments -> Settings
Verify that the Support phone number field is empty and that no errors appear
Perform a chance in any other part of the settings (i.e. Toggle multi-currency or a payment method)
Click Save Changes
The changes should be saved successfully
Update the support number to an invalid number
The "Please enter a valid phone number error appears"
The "Save changes" button is disabled
Use +1 0000000000 as the support phone number, no errors should appear and the Save Changes button is enabled.
Use a valid phone number, no error should appear and the Save Changes button is enabled.
Once all the previous tests are done, you can click "Save Changes", please note that once a number is saved, it cannot be removed, so you won't be able to repeat the previous steps unless you onboard with a new Stripe account.
Once the phone has been saved, clear the Support Phone Number field. The error "Support phone number cannot be empty once it has been set before, please specify." appears and the Save Changes button is disabled.
Checkout Page
Payment Settings (non-US)
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge