Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release branch for 8.6.0 #9852

Merged
merged 56 commits into from
Dec 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c17812e
fix: E_DEPRECATED on BNPL empty PMME (#9689)
frosso Nov 11, 2024
2f8071c
chore: update BNPL constructor descriptions (#9696)
frosso Nov 11, 2024
435732f
Payouts: Change spotlight notice illustration (#9701)
nagpai Nov 11, 2024
b647d8d
Handle IPP failure webhooks (#9705)
mgascam Nov 12, 2024
4677c85
Rename 'deposit' to 'payout' in readme.txt. (#9706)
shendy-a8c Nov 13, 2024
733734b
Update E2E PW screenshots (#9712)
danielmx-dev Nov 13, 2024
dbcc4ba
Minor improvements to WooPay test coverage (#9671)
malithsen Nov 13, 2024
f7ef37d
Merge trunk v8.5.0 into develop
botwoo Nov 14, 2024
dc35740
chore: cleanup of PRB implementation in favor of ECE (#9698)
frosso Nov 14, 2024
faf5ef7
Fix manual capture status source (#9708)
timur27 Nov 14, 2024
2d56a1e
E2E PW Tests: Disable all visual regression tests (#9718)
danielmx-dev Nov 14, 2024
47739ad
Check that cart total is not zero before rendering express checkout (…
dmvrtx Nov 14, 2024
04878e2
Fix alignment issue for the warning icon in settings. (#9711)
brettshumaker Nov 14, 2024
05e2f8d
Validate required billing fields using data from objects instead of c…
danielmx-dev Nov 14, 2024
a69fc47
chore: rename tokenized prb flag to ece (#9715)
frosso Nov 15, 2024
7e9d704
fix: CSS files for express checkout element (#9728)
frosso Nov 15, 2024
f31d8ee
fix: WooPay direct checkout docblock name (#9729)
frosso Nov 15, 2024
f358e9d
chore: ECE copy for tokenized cart implementation (#9730)
frosso Nov 15, 2024
0df81cc
chore: rename wrapper from payment-request to ECE (#9731)
frosso Nov 15, 2024
ee76cd2
Update `upload-artifact` action to v4 (#9743)
achyuthajoy Nov 18, 2024
6a35220
Display credit card brand icons on order received page (#9734)
mdmoore Nov 18, 2024
de288c3
refactor: ECE utility for button UI interactions (#9744)
frosso Nov 19, 2024
02ba76e
chore: remove argument passed to withBlockOverride function (#9747)
frosso Nov 19, 2024
cefc47f
chore: remove args from ece handlers (#9754)
frosso Nov 19, 2024
25ef816
chore: port ece changes into tokenized ece (#9759)
frosso Nov 19, 2024
f7c3ef7
Prevent challenging Klarna inquiries (#9741)
brucealdridge Nov 20, 2024
f084687
chore: ECE phpunit test location fix (#9758)
frosso Nov 20, 2024
85fe9de
refactor: express checkout initialization page checks (#9745)
frosso Nov 20, 2024
e2610f5
fix: missing ECE is_product_page checks (#9765)
frosso Nov 20, 2024
6198974
fix: ECE container retrieval on shortcode checkout (#9767)
frosso Nov 20, 2024
6076463
fix: imports of tokenized ECE referring to wrong path (#9756)
frosso Nov 20, 2024
0cefbcf
Limit Stripe Link to checkout forms (#9753)
mdmoore Nov 20, 2024
145da0a
Show "Download" label on documents list view table (#9763)
Jinksi Nov 20, 2024
51d9ba4
feat: add filter to override rich payment method label (#9783)
frosso Nov 22, 2024
b49f724
Ensure the BNPL PMME doesn't appear on carts with subscriptions (#9774)
mdmoore Nov 22, 2024
986f195
feat: tokenized cart ECE base implementation (#9739)
frosso Nov 22, 2024
8b1bcda
Ensure that tax is enabled before determining how it is calculated (#…
asumaran Nov 22, 2024
0c9010a
Ensure dispute urls in order notes are encoded correctly (#9788)
brucealdridge Nov 25, 2024
04a023c
Set mandatory support phone (#9766)
dpaun1985 Nov 25, 2024
5c0bffc
fix: remove 'test mode' badge from shortcode checkout (#9800)
frosso Nov 25, 2024
b66a6ab
chore: rename PRB constants to ECE (#9768)
frosso Nov 25, 2024
4bea82a
Enable ECE Tracks Events when WooPay is disabled (#9793)
rafaelzaleski Nov 25, 2024
018b219
Merge trunk v8.5.1 into develop
botwoo Nov 25, 2024
c0c4c4f
Update phpcompatibility to develop version to get sniffs for PHP 8 (#…
alopezari Nov 26, 2024
ce4553e
Enforce proper return types for methods get_order_from_event_body (#9…
mgascam Nov 26, 2024
235ec60
Remove redundant stripe payment elements mount for pay for order (#9813)
timur27 Nov 26, 2024
d8192f7
Wait for Stripe js to load before using it (#9770)
danielmx-dev Nov 26, 2024
3717ed9
Fix WooPay trial subscriptions purchases (#9778)
alefesouza Nov 27, 2024
1137c62
Fix return types in DocBlocks (#9815)
mgascam Nov 27, 2024
e47c67a
Update references to woocommerce_payments_server (#9824)
achyuthajoy Nov 28, 2024
0827530
Allow redirect to the settings page from WCPay connect (#9827)
oaratovskyi Nov 28, 2024
24f3972
Use paragraph selector instead of label for pmme appearance (#9840)
gpressutto5 Nov 28, 2024
6012025
Fix WooPay component spacing (#9748)
alefesouza Nov 29, 2024
b0b67af
Payouts: Add payout bank reference key to payout reports and CSV (#9832)
nagpai Nov 29, 2024
e0b69be
Ensure ECE button load events are triggered for multiple buttons on t…
rafaelzaleski Nov 29, 2024
1c5e5bf
Update version and add changelog entries for release 8.6.0
github-actions[bot] Dec 1, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ vendor/*
release/*
tests/e2e/docker*
tests/e2e/deps*

# We'll delete the directory and its contents as part of https://github.com/Automattic/woocommerce-payments/issues/9722 .
# ignoring it because we're temporariily cleaning it up.
client/tokenized-payment-request
2 changes: 1 addition & 1 deletion .github/actions/e2e-pw/run-log-tests/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ runs:
# Use +e to trap errors when running E2E tests.
shell: /bin/bash +e {0}
run: npm run test:e2e-pw-ci
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down
34 changes: 17 additions & 17 deletions .github/workflows/e2e-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,23 +18,23 @@ on:
description: "Branch to be used for running tests"

env:
E2E_GH_TOKEN: ${{ secrets.E2E_GH_TOKEN }}
WCP_DEV_TOOLS_REPO: ${{ secrets.WCP_DEV_TOOLS_REPO }}
WCP_DEV_TOOLS_BRANCH: 'trunk'
WCP_SERVER_REPO: ${{ secrets.WCP_SERVER_REPO }}
WC_SUBSCRIPTIONS_REPO: ${{ secrets.WC_SUBSCRIPTIONS_REPO }}
E2E_BLOG_ID: ${{ secrets.E2E_BLOG_ID }}
E2E_BLOG_TOKEN: ${{ secrets.E2E_BLOG_TOKEN }}
E2E_USER_TOKEN: ${{ secrets.E2E_USER_TOKEN }}
WC_E2E_SCREENSHOTS: 1
E2E_SLACK_CHANNEL: ${{ secrets.E2E_SLACK_CHANNEL }}
E2E_SLACK_TOKEN: ${{ secrets.E2E_SLACK_TOKEN }}
E2E_USE_LOCAL_SERVER: false
E2E_RESULT_FILEPATH: 'tests/e2e/results.json'
WCPAY_USE_BUILD_ARTIFACT: ${{ inputs.wcpay-use-build-artifact }}
WCPAY_ARTIFACT_DIRECTORY: 'zipfile'
NODE_ENV: 'test'
FORCE_E2E_DEPS_SETUP: true
E2E_GH_TOKEN: ${{ secrets.E2E_GH_TOKEN }}
WCP_DEV_TOOLS_REPO: ${{ secrets.WCP_DEV_TOOLS_REPO }}
WCP_DEV_TOOLS_BRANCH: 'trunk'
TRANSACT_PLATFORM_SERVER_REPO: ${{ secrets.TRANSACT_PLATFORM_SERVER_REPO }}
WC_SUBSCRIPTIONS_REPO: ${{ secrets.WC_SUBSCRIPTIONS_REPO }}
E2E_BLOG_ID: ${{ secrets.E2E_BLOG_ID }}
E2E_BLOG_TOKEN: ${{ secrets.E2E_BLOG_TOKEN }}
E2E_USER_TOKEN: ${{ secrets.E2E_USER_TOKEN }}
WC_E2E_SCREENSHOTS: 1
E2E_SLACK_CHANNEL: ${{ secrets.E2E_SLACK_CHANNEL }}
E2E_SLACK_TOKEN: ${{ secrets.E2E_SLACK_TOKEN }}
E2E_USE_LOCAL_SERVER: false
E2E_RESULT_FILEPATH: 'tests/e2e/results.json'
WCPAY_USE_BUILD_ARTIFACT: ${{ inputs.wcpay-use-build-artifact }}
WCPAY_ARTIFACT_DIRECTORY: 'zipfile'
NODE_ENV: 'test'
FORCE_E2E_DEPS_SETUP: true

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-pw-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
E2E_GH_TOKEN: ${{ secrets.E2E_GH_TOKEN }}
WCP_DEV_TOOLS_REPO: ${{ secrets.WCP_DEV_TOOLS_REPO }}
WCP_DEV_TOOLS_BRANCH: 'trunk'
WCP_SERVER_REPO: ${{ secrets.WCP_SERVER_REPO }}
TRANSACT_PLATFORM_SERVER_REPO: ${{ secrets.TRANSACT_PLATFORM_SERVER_REPO }}
WC_SUBSCRIPTIONS_REPO: ${{ secrets.WC_SUBSCRIPTIONS_REPO }}
E2E_BLOG_ID: ${{ secrets.E2E_BLOG_ID }}
E2E_BLOG_TOKEN: ${{ secrets.E2E_BLOG_TOKEN }}
Expand Down
32 changes: 16 additions & 16 deletions .github/workflows/e2e-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@ on:
workflow_dispatch:

env:
E2E_GH_TOKEN: ${{ secrets.E2E_GH_TOKEN }}
WCP_DEV_TOOLS_REPO: ${{ secrets.WCP_DEV_TOOLS_REPO }}
WCP_DEV_TOOLS_BRANCH: 'trunk'
WCP_SERVER_REPO: ${{ secrets.WCP_SERVER_REPO }}
WC_SUBSCRIPTIONS_REPO: ${{ secrets.WC_SUBSCRIPTIONS_REPO }}
E2E_BLOG_ID: ${{ secrets.E2E_BLOG_ID }}
E2E_BLOG_TOKEN: ${{ secrets.E2E_BLOG_TOKEN }}
E2E_USER_TOKEN: ${{ secrets.E2E_USER_TOKEN }}
WC_E2E_SCREENSHOTS: 1
E2E_SLACK_CHANNEL: ${{ secrets.E2E_SLACK_CHANNEL }}
E2E_SLACK_TOKEN: ${{ secrets.E2E_SLACK_TOKEN }}
E2E_USE_LOCAL_SERVER: false
E2E_RESULT_FILEPATH: 'tests/e2e/results.json'
WC_MIN_SUPPORTED_VERSION: '7.6.0'
NODE_ENV: 'test'
FORCE_E2E_DEPS_SETUP: true
E2E_GH_TOKEN: ${{ secrets.E2E_GH_TOKEN }}
WCP_DEV_TOOLS_REPO: ${{ secrets.WCP_DEV_TOOLS_REPO }}
WCP_DEV_TOOLS_BRANCH: 'trunk'
TRANSACT_PLATFORM_SERVER_REPO: ${{ secrets.TRANSACT_PLATFORM_SERVER_REPO }}
WC_SUBSCRIPTIONS_REPO: ${{ secrets.WC_SUBSCRIPTIONS_REPO }}
E2E_BLOG_ID: ${{ secrets.E2E_BLOG_ID }}
E2E_BLOG_TOKEN: ${{ secrets.E2E_BLOG_TOKEN }}
E2E_USER_TOKEN: ${{ secrets.E2E_USER_TOKEN }}
WC_E2E_SCREENSHOTS: 1
E2E_SLACK_CHANNEL: ${{ secrets.E2E_SLACK_CHANNEL }}
E2E_SLACK_TOKEN: ${{ secrets.E2E_SLACK_TOKEN }}
E2E_USE_LOCAL_SERVER: false
E2E_RESULT_FILEPATH: 'tests/e2e/results.json'
WC_MIN_SUPPORTED_VERSION: '7.6.0'
NODE_ENV: 'test'
FORCE_E2E_DEPS_SETUP: true

jobs:
generate-matrix:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/php-compatibility.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
name: PHP Compatibility

on:
pull_request
#pull_request # Workflow disabled temporarily until PHP Compatibility fixes are in place
workflow_dispatch

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
Expand Down
4 changes: 4 additions & 0 deletions assets/css/success.css
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,7 @@
.wc-payment-gateway-method-logo-wrapper.wc-payment-lpm-logo img {
max-height: 26px;
}

.wc-payment-gateway-method-logo-wrapper.wc-payment-card-logo img {
max-height: 1em;
}
12 changes: 1 addition & 11 deletions assets/images/cards/jcb.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/images/illustrations/setup.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
33 changes: 33 additions & 0 deletions changelog.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,38 @@
*** WooPayments Changelog ***

= 8.6.0 - 2024-12-04 =
* Add - Add Bank reference key column in Payout reports. This will help reconcile WooPayments Payouts with bank statements.
* Add - Display credit card brand icons on order received page.
* Fix - Add support to load stripe js asynchronously when it is not immediately available in the global scope.
* Fix - Add the missing "Download" column heading label and toggle menu option to the Payments → Documents list view table.
* Fix - Ensure ECE button load events are triggered for multiple buttons on the same page.
* Fix - Ensure ECE is displayed correctly taking into account the tax settings.
* Fix - Evidence submission is no longer available for Klarna inquiries as this is not supported by Stripe / Klarna.
* Fix - fix: express checkout to use its own css files.
* Fix - fix: missing ece is_product_page checks
* Fix - Fix ECE Tracks events not triggering when WooPay is disabled.
* Fix - Fix WooPay component spacing.
* Fix - Fix WooPay trial subscriptions purchases.
* Fix - Make sure the status of manual capture enablement is fetched from the right place.
* Fix - Prevent express checkout from being used if cart total becomes zero after coupon usage.
* Fix - Resolved issue with terminal payments in the payment intent failed webhook processing.
* Fix - Set the support phone field as mandatory in the settings page.
* Fix - Update Link logo alignment issue when WooPay is enabled and a specific version of Gutenberg is enabled.
* Fix - Use paragraph selector instead of label for pmme appearance
* Fix - Validate required billing fields using data from objects instead of checking the labels.
* Update - Avoid getting the appearance for pay for order page with the wrong appearance key.
* Update - chore: rename wrapper from payment-request to express-checkout
* Update - feat: add `wcpay_checkout_use_plain_method_label` filter to allow themes or merchants to force the "plain" WooPayments label on shortcode checkout.
* Update - refactor: express checkout initialization page location checks
* Update - refactor: express checkout utility for button UI interactions
* Dev - Allow redirect to the settings page from WCPay connect
* Dev - chore: removed old PRB implementation for ApplePay/GooglePay in favor of the ECE implementation; cleaned up ECE feature flag;
* Dev - Disable visual regression testing from Playwright until a more reliable approach is defined.
* Dev - Ensure proper return types in the webhook processing service.
* Dev - fix: E_DEPRECATED on BNPL empty PMME
* Dev - Fix return types
* Dev - Update snapshots for E2E Playwright screenshots

= 8.5.1 - 2024-11-25 =
* Fix - fix: remove "test mode" badge from shortcode checkout.

Expand Down
9 changes: 7 additions & 2 deletions client/cart/blocks/product-details.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { select } from '@wordpress/data';
* Internal dependencies
*/
import { getAppearance, getFontRulesFromPage } from 'wcpay/checkout/upe-styles';
import { useStripeAsync } from 'wcpay/hooks/use-stripe-async';
import { getUPEConfig } from 'utils/checkout';
import WCPayAPI from '../../checkout/api';
import request from '../../checkout/utils/request';
Expand Down Expand Up @@ -47,6 +48,8 @@ const ProductDetail = ( { cart, context } ) => {

const [ fontRules ] = useState( getFontRulesFromPage() );

const stripe = useStripeAsync( api );

useEffect( () => {
async function generateUPEAppearance() {
// Generate UPE input styles.
Expand All @@ -63,6 +66,10 @@ const ProductDetail = ( { cart, context } ) => {
}
}, [ appearance ] );

if ( ! stripe ) {
return null;
}

if ( Object.keys( appearance ).length === 0 ) {
return null;
}
Expand Down Expand Up @@ -91,8 +98,6 @@ const ProductDetail = ( { cart, context } ) => {
countryCode: country, // Customer's country or base country of the store.
};

const stripe = api.getStripe();

return (
<div className="wc-block-components-bnpl-wrapper">
<Elements
Expand Down
Loading
Loading