Change variation's single_add_to_cart_text() #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Product::get_add_to_cart_text() as default value. This avoids the `woocommerce_product_add_to_cart_text` filter. Closes Automattic#741.
mattallan
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks @helgatheviking for fixing this for us!
I couldn't figure out why our variation product class was using self::add_to_cart_text() but our variable and single products were using WC_Subscriptions_Product::get_add_to_cart_text() 🤔
This code hasn't been touched in 9years so I suspect it was an oversight from when it was originally developed.
trunk |
this branch |
|---|---|
 |
 |
|
Happy to... I caught it while I was fixing an issue in my own dusty code. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to use
WC_Subscriptions_Product::get_add_to_cart_text()as default value. This avoids thewoocommerce_product_add_to_cart_textfilter. Closes #741.