Load HTML in product name on shipping rates #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefesouza
commented
Jan 11, 2025
| @@ -108,7 +108,7 @@ function wcs_cart_totals_shipping_html() { | |||
| <?php wcs_cart_print_shipping_input( $recurring_cart_package_key, $shipping_method ); ?> | |||
| <?php do_action( 'woocommerce_after_shipping_rate', $shipping_method, $recurring_cart_package_key ); ?> | |||
| <?php if ( ! empty( $show_package_details ) ) : ?> | |||
| <?php echo '<p class="woocommerce-shipping-contents"><small>' . esc_html( $package_details ) . '</small></p>'; ?> | |||
| <?php echo '<p class="woocommerce-shipping-contents"><small>' . wp_kses_post( apply_filters( 'woocommerce_cart_item_name', $package_details ) ) . '</small></p>'; ?> | |||
There was a problem hiding this comment.
I used the same approach used by the product name on the cart page here.
mattallan
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Thanks so much @alefesouza for fixing this!
- One small thing, do you mind adding a changelog entry for this one before merging it?
Code looks good and tests well. Approving this :)
This fix for the cart and checkout blocks is included on woocommerce/woocommerce#54386.
Amazing 💯
| Old | Fixed |
|---|---|
 |
 |
Also confirmed shortcode checkout page:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce-subscriptions#4128
Description
This PR fixes raw HTML being shown to the user on the shipping rates section of the classic cart and checkout page when the product name contains HTML.
This fix for the cart and checkout blocks is included on woocommerce/woocommerce#54386.
How to test this PR
Product impact