Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node version mismatch in .nvmrc and package.json. #795

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

c-shultz
Copy link

Fixes #230

Description

Node version in package.json is 16.17.1 and .nvmrc was set to LTS which is no longer compatible with package versions. This PR updates the .nvrmc to 16.17.1 to avoid build errors.

How to test this PR

  1. Do a fresh clone of repo.
  2. Run nvm use
  3. Run npm install
  4. Run npm run build

Product impact

  • Added changelog entry (or does not apply)
  • Will this PR affect WooCommerce Subscriptions? yes/no/tbc, add issue ref
  • Will this PR affect WooCommerce Payments? yes/no/tbc, add issue ref
  • Added deprecated functions, hooks or classes to the spreadsheet

@c-shultz
Copy link
Author

I see there is also a now outdated WiP PR to update the packages to Node 18 compatibility: #231

Anything older than Node 18 is now unmaintained. Should an issue be opened to update Node and package versions?

@c-shultz c-shultz requested review from a team and james-allan and removed request for a team February 24, 2025 22:40
Copy link
Contributor

@james-allan james-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. 👍

I confirmed that the previous nvm version (lts) failed to build, but the build succeeds on this branch using version 16.17.1. Additionally, this version is consistent with the version mentioned in the README.

Thanks @c-shultz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error when using the current Node LTS v18
2 participants