Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic validation to enclosure function #1028

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Add basic validation to enclosure function #1028

merged 3 commits into from
Nov 30, 2024

Conversation

pfefferle
Copy link
Member

/cc @akirk

Fixes Fatal errors if the enclosure meta does not match the core-format.

@pfefferle pfefferle requested a review from akirk November 29, 2024 14:45
@pfefferle pfefferle self-assigned this Nov 29, 2024
@akirk akirk mentioned this pull request Nov 29, 2024
Merged
akirk
akirk approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

akirk
akirk requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the invalid values using array_filter()

@pfefferle
Copy link
Member Author

There is an array_filter and it also filters false.

@pfefferle pfefferle requested a review from akirk November 29, 2024 17:36
akirk
akirk approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. I missed that!

@pfefferle pfefferle merged commit e8e8706 into trunk Nov 30, 2024
24 checks passed
@pfefferle pfefferle deleted the improve/enclosure-validation branch November 30, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akirk akirk akirk approved these changes

Assignees

@pfefferle pfefferle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfefferle @akirk