Clean up options and meta on uninstall #1134
Conversation
|
I like to cleanup in general, but this is very destructive and might cause some data loss by accident, even more because it was different before! What about adding a consent layer when the user clicks the remove link or adding a "remove and delete all data" link? |
This only runs when the plugin gets deleted, not when it's deactivated.
Core has a built-in "Are You Sure" modal when you try to delete a plugin. 
|
includes/class-activitypub.php
Outdated
| delete_metadata( 'user', 0, 'activitypub_default_extra_fields', '', true ); | ||
| delete_metadata( 'user', 0, 'activitypub_followers', '', true ); | ||
| delete_metadata( 'user', 0, 'magic_sig_public_key', '', true ); | ||
| delete_metadata( 'user', 0, 'magic_sig_private_key', '', true ); | ||
|
|
||
| delete_metadata( 'post', 0, '_activitypub_actor_json', '', true ); | ||
| delete_metadata( 'post', 0, '_activitypub_canonical_url', '', true ); | ||
| delete_metadata( 'post', 0, '_activitypub_errors', '', true ); | ||
| delete_metadata( 'post', 0, '_activitypub_inbox', '', true ); | ||
| delete_metadata( 'post', 0, '_activitypub_user_id', '', true ); | ||
| delete_metadata( 'post', 0, 'activitypub_content_warning', '', true ); | ||
| delete_metadata( 'post', 0, 'activitypub_content_visibility', '', true ); |
There was a problem hiding this comment.
As discussed: let's split this PR and start with cleaning up the options. I would love to have an export of the followers, before we delete them permanantly.
What do you think @Automattic/fediverse
obenland
force-pushed
the
add/post-meta-cleanup
branch
from
899bf53 to
4cbd132
Compare
CHANGELOG.md
Outdated
| @@ -48,6 +48,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| * Comment counts get updated when the plugin is activated/deactivated/deleted | |||
| * Added a filter to make custom comment types manageable in WP.com Calypso | |||
| * Cleanup of option values when the plugin is uninstalled | |||
There was a problem hiding this comment.
this is in the wrong version now
readme.txt
Outdated
| @@ -155,6 +155,7 @@ For reasons of data protection, it is not possible to see the followers of other | |||
|
|
|||
| * Added: Comment counts get updated when the plugin is activated/deactivated/deleted | |||
| * Added: A filter to make custom comment types manageable in WP.com Calypso | |||
| * Added: Cleanup of option values when the plugin is uninstalled | |||
Proposed changes:
Is there more data that we add, that should be removed here?