Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow federating arbitrary data #1235

Closed
wants to merge 133 commits into from
Closed

Conversation

pfefferle
Copy link
Member

This PR uses the data you pass to the Activity via set_object to keep all the custom attributes.

pfefferle and others added 14 commits January 28, 2025 10:55
* Outbox: Correctly handle attachments

* Update function docs to reflect reality

* Aside: Add some context as to why this callback is necessary
* Outbox: Fix deletes

* Always send deletes
* Outbox: Basic rescheduling

* add tests

* Add tests

* reuse ActivityPub_Outbox_TestCase class

* fix phpcs issues

* update tests

* fix tests

* fix tests

* debug

* debug

* types?

* add missing hook

props @obenland

* simpified code

props @obenland

* remove unused namespace definitions

---------

Co-authored-by: Konstantin Obenland <[email protected]>
* Outbox: Make post type non-hierarchical

* Default to title and content

It helps when setting the post type to public to debug something
* Outbox: Account for transformer errors

* Remove debug
* Outbox: Account for invalid json

* http it is!

* Remove unnecessary init
This PR uses the data you pass to the Activity via `set_object` to keep all the custom attributes.
@pfefferle pfefferle changed the base branch from trunk to add/outbox-collection January 29, 2025 16:31
@pfefferle pfefferle requested a review from obenland January 29, 2025 16:31
@pfefferle pfefferle added the Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. label Jan 29, 2025
jeherve
jeherve previously approved these changes Jan 29, 2025
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked in my tests, thank you!

@pfefferle pfefferle self-assigned this Jan 29, 2025
@pfefferle pfefferle marked this pull request as draft January 29, 2025 17:43
@pfefferle pfefferle changed the title Outbox: Fix profile updates (once again) WIP: Allow federating arbitrary data Jan 29, 2025
@pfefferle pfefferle added this to the Outbox milestone Jan 29, 2025
Base automatically changed from add/outbox-collection to trunk January 31, 2025 06:52
@pfefferle pfefferle dismissed jeherve’s stale review January 31, 2025 06:52

The base branch was changed.

@github-actions github-actions bot added [Feature] Collections [Focus] Compatibility Ensuring the plugin plays well with other plugins labels Jan 31, 2025
@pfefferle pfefferle closed this Feb 5, 2025
@pfefferle pfefferle deleted the fix/profile-updates-2 branch February 5, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Collections [Focus] Compatibility Ensuring the plugin plays well with other plugins Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants