Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move: Add cli command to update domains #1417

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

obenland
Copy link
Member

@obenland obenland commented Mar 4, 2025

Proposed changes:

  • Adds CLI command to update activitypub users with a domain change.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Go to '..'

@obenland obenland requested a review from a team March 4, 2025 21:25
@obenland obenland self-assigned this Mar 4, 2025
@obenland
Copy link
Member Author

obenland commented Mar 4, 2025

Pretty much untested so far.

I'm not super happy with the name of the subcommand, any ideas on how to improve that?

@pfefferle
Copy link
Member

pfefferle commented Mar 4, 2025

Move is the technical term but I think we do not have to use it for the user facing command. What about change_domain instead?

Btw. Doesn't core cli use - as delimiter? change-domain?

@mattwiebe
Copy link
Contributor

I think in order for this to work, we'd need to be serving both domains to the current site at the time the command is run, with neither profile redirecting to their cross domain counterpart?

I also wonder if we need to add some other hooks in the case that we're serving a profile from the non-canonical domain? Are there other fields we need to keep track of and vary depending on the domain being served? 😵‍💫

@pfefferle
Copy link
Member

pfefferle commented Mar 7, 2025

Aside from what @mattwiebe stated, this won't work, because the current code always fetches the Actor based on the $from URL, this will break, because either you would have to trigger it with the old domain still running -> this would break the lookup for the new domain, or, if you already configured the new domain for the blog, the internal Actor lookup would fail because of the domain mismatch.

Please have a look at: #1413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants