-
Notifications
You must be signed in to change notification settings - Fork 3
Implements update /posts endpoint and its integration tests
#304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b4e3ae3 to
ff1a470
Compare
/posts endpoint and its integration tests /posts endpoint and its integration tests
/posts endpoint and its integration tests /posts endpoint and its integration tests
|
Anything in In that case, I wonder if a separate crate would be the way to go – it could contain a second-level set of parsers for common core-level data stored there? |
ff1a470 to
979965b
Compare
jkmassel
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements update
/postsendpoint and its integration tests following established patterns. It provides 100% integration test coverage - as far as I am aware - for individual field updates. I believe/postsis one of the most important endpoints for us, and the extra coverage will provide helpful. I am even thinking about going back to create/postsendpoint and adding more tests for it.I've changed the timezone of the test site, so that the
date&date_gmtvalues would be different which should help us avoid related false positive tests.The
meta.footnotesreturn a JSON string that contains a JSON array. I've added a custom parser and serializer for this, so that we can work with strong types. It seems to be working well at the moment, but it's entirely possible that I am missing some conditions which hopefully will pop-up as we add more WordPress versions and test sites.