Create /media endpoint
#410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
commented
Dec 2, 2024
| multipartBodyBuilder.addFormDataPart(k, v) | ||
| } | ||
| val file = | ||
| WpRequestExecutor::class.java.classLoader?.getResource(mediaUploadRequest.filePath())?.file?.let { |
There was a problem hiding this comment.
I am not sure if this is the correct way to get the file in Android. I think it's correct, but we might need to pass a function in the initializer so it can be configured.
I am leaving it as is for now and we can address it if we find that it's not working when we integrate it to WordPress-Android.
oguzkocer
force-pushed
the
create-media-2
branch
from
96be16e to
593db7e
Compare
oguzkocer
requested review from
jkmassel and
crazytonyli
and removed request for
jkmassel
jkmassel
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
This works for me over in #412.
The code looks fine, the Android stuff included. That might be worth adding to the example app to be sure, but that could be a subsequent PR.
I took the liberty of pushing a commit to put Swift stubs in place to unblock CI.
jkmassel
added a commit
that referenced
this pull request
Dec 3, 2024
* Create `/media` endpoint * Manually implement create media response type and endpoint * Restore test server from Kotlin * impl From<MediaCreateParams> for HashMap<String, String> * Implement MediaUploadRequestExecutionError * Removed addressed TODO from Kotlin WpRequestExecutor * Add file_path to MediaFileNotFound error * Patch up failing Swift stuff --------- Co-authored-by: Jeremy Massel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements create
/mediaendpoint. Due to its custom nature, it does NOT follow the established patterns, but instead requires some new patterns:MediaUploadRequestthat's similar toWpNetworkRequest, but it includes information such asfile_path&file_content_type.MediaUploadRequestExecutionErrorwhich is similar toRequestExecutionErrorbut it has an extra variantMediaFileNotFound. We can add more error types specific to media uploads here.RequestExecutorto upload media that uses the newMediaUploadRequestandMediaUploadRequestExecutionError.MediaUploadRequestusesmultipart/form-datacontent type header value and adds the parameters as form values. The header value is included in itsheader_mapand the key value pairs forMediaCreateParamscan be accessed from itsmedia_params()function.I am a little concerned about the
clones inWpNetworkRequest&MediaUploadRequestand not entirely sure about the correct way to do this. From pure Rust perspective, this is definitely wrong. However, these types have to be cloned for FFI - or shared as a pointer. So, maybe we need to separate how Rust uses it and how it's exposed through FFI. I don't want to hold up this PR for this, so I opened a separate issue for it: #416