More auto discovery tests #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds most of the test cases from #265. The successful test cases were already working, except for one case where we needed to add some
reqwestfeatures to handle different response types.It adds one test for handling an error case. This is currently bare bones as we are not confirming what type of error we are getting. We'll be working on improving the url discovery result type. Once that's complete we can improve on this test.
Note that with this PR, the only remaining case in #265 is
https://aggressive-caching.wpmt.cowhich requires us to implement full html parsing to find the link header. This will happen in a separate PR.