Use strum to replace manual implementation of as_str
and FromStr
#487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the two core changes:
strum_macros::EnumString
derive macro to replace our ownFromStr
implementation.strum_macros::Display
derive macro to replace our ownas_str
implementation. The macro addsstd::fmt::Display
implementation to the attached enums.Breaking change
The enums now no longer have the
as_str
function. Instead, they haveto_string
.Do not use
strum_macros::AsRefStr
strum also has a derive macro
AsRefStr
to addfn as_ref() -> AsRef<str>
to the attached enums. However, the function does not match theto_string
implementation generated bystrum_macros::Display
macro. TheCustom(String)
variant returns"Custom"
, instead of theString
value in the tuple.