Rework auto discovery experience #514
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
fa523b0 to
f2c1d33
Compare
* Adds auto discovery attempt type * Remove state machine from login auto discovery * Rework auto discovery results * Implement helpers for AutoDiscoveryAttemptResult & AutoDiscoveryAttemptFailure * Rename AutoDiscoveryAttemptType::Original as UserInput * Add attempt specific fields to AutoDiscoveryUniffiResult
* Introduces RequestExecutionErrorReason * Optionally track redirects in RequestExecutionError
…` helper (#518) * Refactor auto discovery attempt to have a separate `find_api_root_url` helper * Remove an incorrect use statement from login_client
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
42bedeb to
ca23ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all the changes we are making to the auto discovery experience. I am opening this PR early so that we can see the CI state as we merge PRs into the feature branch.