Add Invalid SSL support and redirect tracking in Swift #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
changed the base branch from
trunk
to
feature/rework-auto-discovery-result
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
fa523b0 to
f2c1d33
Compare
jkmassel
force-pushed
the
add/invalid-ssl-support
branch
from
0f86ff8 to
cfe817c
Compare
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
f2c1d33 to
fa523b0
Compare
* Adds auto discovery attempt type * Remove state machine from login auto discovery * Rework auto discovery results * Implement helpers for AutoDiscoveryAttemptResult & AutoDiscoveryAttemptFailure * Rename AutoDiscoveryAttemptType::Original as UserInput * Add attempt specific fields to AutoDiscoveryUniffiResult
* Introduces RequestExecutionErrorReason * Optionally track redirects in RequestExecutionError
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
fa523b0 to
d4fe96d
Compare
jkmassel
force-pushed
the
add/invalid-ssl-support
branch
from
cfe817c to
141dd33
Compare
…` helper (#518) * Refactor auto discovery attempt to have a separate `find_api_root_url` helper * Remove an incorrect use statement from login_client
This is probably not the right way to do it, but it works for now
jkmassel
force-pushed
the
add/invalid-ssl-support
branch
from
0f72aeb to
ca7abfc
Compare
jkmassel
force-pushed
the
add/invalid-ssl-support
branch
from
b1394c1 to
c2da5fe
Compare
jkmassel
force-pushed
the
add/invalid-ssl-support
branch
from
c59625c to
6a58637
Compare
oguzkocer
force-pushed
the
feature/rework-auto-discovery-result
branch
from
42bedeb to
ca23ef1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.