MSD Notifications: Add a clarifying link to Sites notifications settings to the Achievements toggle - #112466
Merged
Copons merged 2 commits intoJul 9, 2026
Conversation
…nts notification toggle.
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
arthur791004
approved these changes
Jul 9, 2026
Copons
added this pull request to the merge queue
Jul 9, 2026
Contributor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Copons
deleted the
update/msd-achievement-notifications-site-settings-link
branch
July 9, 2026 12:15
|
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/34254783 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @Copons for including a screenshot in the description! This is really helpful for our translators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #112442
Proposed Changes
/me/notifications/sitesfrom the global Achievements notifications card.Why are these changes being made?
The global Achievements notifications toggle was originally introduced in
/reader/users/me/achievements, where it included (and still does) a link to/me/notifications, to clarify where to find site-level Achievements settings.When the toggle was moved to `/me/notifications, the link was correctly dropped.
However, the MSD version of Notifications splits Sites and Extras settings. The Achievements setting is now in Extras, separated from Sites, so it needs the link again.
Testing Instructions
https://my.wordpress.com/me/notifications/extras./me/notifications/sites.Pre-merge Checklist