Skip to content

MSD Notifications: Add a clarifying link to Sites notifications settings to the Achievements toggle #112466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Copons merged 2 commits into from
Jul 9, 2026
Merged

MSD Notifications: Add a clarifying link to Sites notifications settings to the Achievements toggle #112466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db42ced
Add a clarifying link to site notifications settings to the Achieveme…
Copons Jul 9, 2026
bde810b
Fix tests expecting a string that was modified
Copons Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions client/dashboard/me/notifications-extras/achievements-card/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
import { userPreferenceOptimisticMutation, userPreferenceQuery } from '@automattic/api-queries';
import { useMutation, useSuspenseQuery } from '@tanstack/react-query';
import { Link } from '@tanstack/react-router';
import { ToggleControl } from '@wordpress/components';
import { useDispatch } from '@wordpress/data';
import { createInterpolateElement } from '@wordpress/element';
import { __, sprintf } from '@wordpress/i18n';
import { store as noticesStore } from '@wordpress/notices';
import { useAnalytics } from '../../../app/analytics';
Expand Down Expand Up @@ -45,6 +47,15 @@ export const AchievementsCard = () => {
} );
};

const helpText = createInterpolateElement(
__(
'Receive notifications when you unlock new achievements. This setting overrides <link>site-level settings</link>.'
),
{
link: <Link to="/me/notifications/sites" />,
}
);

return (
<Card>
<CardBody>
Expand All @@ -53,9 +64,7 @@ export const AchievementsCard = () => {
checked={ notifications !== 'disabled' }
disabled={ isPending }
label={ __( 'Achievements' ) }
help={ __(
'Receive notifications when you unlock new achievements. This setting overrides site-level settings.'
) }
help={ helpText }
onChange={ handleChange }
/>
</CardBody>
Expand Down
5 changes: 2 additions & 3 deletions client/dashboard/me/notifications-extras/test/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,10 +249,9 @@ describe( 'NotificationsExtras', () => {
expect( screen.getByText( 'Reminders about your posts from past years.' ) ).toBeVisible();
expect( screen.getByLabelText( 'Achievements' ) ).toBeVisible();
expect(
screen.getByText(
'Receive notifications when you unlock new achievements. This setting overrides site-level settings.'
)
screen.getByText( /Receive notifications when you unlock new achievements\./ )
).toBeVisible();
expect( screen.getByRole( 'link', { name: 'site-level settings' } ) ).toBeVisible();
} );

it( 'saves the On this day setting when toggled', async () => {
Expand Down
Loading