Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive query params from page context and pass to components #100317

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Feb 25, 2025

Related to #99910 and #99909

The dependency on document.location.search didn't work well

Proposed Changes

  • Use query params from the page context and pass them to components.
  • Update page when it has changed in query params.

Why are these changes being made?

  • Addressing CfT feedback

Testing Instructions

  • Turn on feature flags in your browser's console: window.sessionStorage.setItem('flags', 'calypso/domains-dataviews'])
  • Go to http://calypso.localhost:3000/domains/manage
  • Try to play with pagination settings and click on domains. Then use the browser's back button.
  • Make sure the changes on the screen reflect the changes in the URL.
  • Now go to http://calypso.localhost:3000/domains/manage
  • Go to DataViews settings (the cog above the table) and set 10 domains per page.
  • With the domains we normally get in dev/staging, there should be two pages now.
  • Go to the second page.
  • Click on Domains in the left navigation.
  • Make sure current page is now the first one.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@merkushin merkushin requested a review from a team February 25, 2025 05:54
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 25, 2025
@merkushin merkushin self-assigned this Feb 25, 2025
@matticbot
Copy link
Contributor

matticbot commented Feb 25, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~33 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
hosting       +144 B  (+0.0%)      +33 B  (+0.0%)
domains       +144 B  (+0.0%)      +33 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domains-dataviews-query-params on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
2 participants