Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the delete site url to avoid dashboard redirect. #100810

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Mar 5, 2025

Fixes: #100723

Proposed Changes

Update the redirect URL when users click "Delete site" from /sites.

/settings/delete-site/${ site.slug } to /sites/settings/site/${ site.slug }/delete-site.

Why are these changes being made?

Currently, when a user clicks "Delete site" in the item menu, users are redirected to their wp.com/settings/delete-site/{site} which is then intercepted by redirectToolsIfRemoveDuplicateViewsExperimentEnabled introduced in #98875 and redirect back to /sites/settings/site/${ site.slug }/delete-site. The user then sees their wp-admin dashboard load for a second.

Before

Screen.Capture.on.2025-03-06.at.09-24-51.mp4

After

Screen.Capture.on.2025-03-06.at.09-27-31.mov

Considerations/Questions

The function redirectToolsIfRemoveDuplicateViewsExperimentEnabled relies on isRemoveDuplicateViewsExperimentEnabledto determine whether to redirect, seemingly only redirecting the treatment group.

I'm not sure if this PR should also verify whether the session is untangled or just redirect anyways.

@lsl or @okmttdhr Any thoughts?

Testing Instructions

With an active site

  1. Click on the dropdown menu
  2. Select Delete site
  3. Expect to not see a flash before the Delete site view is loaded.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot
Copy link
Contributor

matticbot commented Mar 5, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~68 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site              +73 B  (+0.0%)      +68 B  (+0.0%)
sites-dashboard           +73 B  (+0.0%)      +68 B  (+0.0%)
site-tools                +73 B  (+0.0%)      +68 B  (+0.0%)
site-settings             +73 B  (+0.0%)      +68 B  (+0.0%)
site-performance          +73 B  (+0.0%)      +68 B  (+0.0%)
site-overview             +73 B  (+0.0%)      +68 B  (+0.0%)
site-monitoring           +73 B  (+0.0%)      +68 B  (+0.0%)
site-marketing            +73 B  (+0.0%)      +68 B  (+0.0%)
site-logs                 +73 B  (+0.0%)      +68 B  (+0.0%)
hosting-features          +73 B  (+0.0%)      +68 B  (+0.0%)
hosting                   +73 B  (+0.0%)      +68 B  (+0.0%)
github-deployments        +73 B  (+0.0%)      +68 B  (+0.0%)
domains                   +73 B  (+0.0%)      +68 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@StevenDufresne StevenDufresne changed the title WIP: Update the delete site url to avoid dashboard redirect. Update the delete site url to avoid dashboard redirect. Mar 6, 2025
@StevenDufresne StevenDufresne marked this pull request as ready for review March 6, 2025 00:31
@StevenDufresne StevenDufresne requested a review from lsl March 6, 2025 00:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 6, 2025
@StevenDufresne StevenDufresne requested a review from okmttdhr March 6, 2025 00:31
Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this, @StevenDufresne!

I'm not sure if this PR should also verify whether the session is untangled or just redirect anyways.

I left a comment about this.

@StevenDufresne StevenDufresne requested a review from okmttdhr March 6, 2025 05:40
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/delete-site-redirect on your sandbox.

Copy link
Member

@okmttdhr okmttdhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked nicely 👍 :D

@StevenDufresne StevenDufresne merged commit 1318942 into trunk Mar 7, 2025
15 checks passed
@StevenDufresne StevenDufresne deleted the fix/delete-site-redirect branch March 7, 2025 00:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on Delete site briefly redirects to the dashboard before showing the delete site setting
3 participants