-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the delete site url to avoid dashboard redirect. #100810
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~68 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing this, @StevenDufresne!
I'm not sure if this PR should also verify whether the session is untangled or just redirect anyways.
I left a comment about this.
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked nicely 👍 :D
Fixes: #100723
Proposed Changes
Update the redirect URL when users click "Delete site" from
/sites
./settings/delete-site/${ site.slug }
to/sites/settings/site/${ site.slug }/delete-site
.Why are these changes being made?
Currently, when a user clicks "Delete site" in the item menu, users are redirected to their
wp.com/settings/delete-site/{site}
which is then intercepted by redirectToolsIfRemoveDuplicateViewsExperimentEnabled introduced in #98875 and redirect back to/sites/settings/site/${ site.slug }/delete-site
. The user then sees their wp-admin dashboard load for a second.Before
Screen.Capture.on.2025-03-06.at.09-24-51.mp4
After
Screen.Capture.on.2025-03-06.at.09-27-31.mov
Considerations/Questions
The function
redirectToolsIfRemoveDuplicateViewsExperimentEnabled
relies onisRemoveDuplicateViewsExperimentEnabled
to determine whether to redirect, seemingly only redirecting the treatment group.I'm not sure if this PR should also verify whether the session is
untangled
or just redirect anyways.@lsl or @okmttdhr Any thoughts?
Testing Instructions
With an active site
Delete site
Pre-merge Checklist