-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A > Marketplace: Fix Category selection on large screens #101228
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@yashwin, we may need to modify the breakpoint rather than removing the rule for larger screens. On ultra-wide screens, the shadow is so small that it disrupts the balance of the UI. Instead of relying on the Core mixins ( |
Thanks for the review, @jkguidaven! I honestly think we shouldn't introduce a new breakpoint, we are using breakpoints from Core. I think this is still fine than not being able to use the filters. @madebynoam: Any thoughts here? |
Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1898
Proposed Changes
This PR fixes the category selection issue on large screens (>1900px)
Why are these changes being made?
Testing Instructions
Pre-merge Checklist