Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A > Marketplace: Fix Category selection on large screens #101228

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Mar 12, 2025

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1898

Proposed Changes

This PR fixes the category selection issue on large screens (>1900px)

Why are these changes being made?

  • To fix a bug with the category selection issue on large screens (>1900px)

Testing Instructions

  • Open the A4A live link
  • Go to Marketplace > Verify you can select the top filters, especially the first and last without any issues.
Before After
Screenshot 2025-03-12 at 3 30 16 PM Screenshot 2025-03-12 at 3 30 20 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team March 12, 2025 10:04
@yashwin yashwin self-assigned this Mar 12, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 12, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/marketplace/category-selection on your sandbox.

@jkguidaven
Copy link
Contributor

jkguidaven commented Mar 12, 2025

@yashwin, we may need to modify the breakpoint rather than removing the rule for larger screens. On ultra-wide screens, the shadow is so small that it disrupts the balance of the UI. Instead of relying on the Core mixins (break-huge) we might have to define a specific breakpoint for this to work effectively.

Before
Screenshot 2025-03-12 at 7 23 59 PM

After
Screenshot 2025-03-12 at 7 20 40 PM

@yashwin
Copy link
Contributor Author

yashwin commented Mar 21, 2025

@yashwin, we may need to modify the breakpoint rather than removing the rule for larger screens. On ultra-wide screens, the shadow is so small that it disrupts the balance of the UI. Instead of relying on the Core mixins (break-huge) we might have to define a specific breakpoint for this to work effectively.

Thanks for the review, @jkguidaven!

I honestly think we shouldn't introduce a new breakpoint, we are using breakpoints from Core. I think this is still fine than not being able to use the filters. @madebynoam: Any thoughts here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants