Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Manual referrals code cleanup #101580

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Mar 19, 2025

Proposed Changes

  • This PR removes the automated referrals logic used throughout A4A, including the Referrals Dashboard and FAQ pages.
  • It also removes the isNewLayout prop from StepSectionItem, as we always use the new layout.

Why are these changes being made?

  • Code cleanup

Testing Instructions

  1. Referrals: Dashboard > Empty view
  2. Referrals: FAQ
  3. Partner Directory: Dashboard
  4. WooPayments: Site up page
  5. Team
  6. Migrations: Commissions > Empty view

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested a review from a team March 19, 2025 09:54
@yashwin yashwin self-assigned this Mar 19, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 19, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 19, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2065 bytes removed 📉 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-referrals              -5317 B  (-0.5%)    -1539 B  (-0.5%)
a8c-for-agencies-woopayments             -346 B  (-0.0%)     -145 B  (-0.1%)
a8c-for-agencies-overview                -281 B  (-0.0%)      -82 B  (-0.0%)
a8c-for-agencies-marketplace             -275 B  (-0.0%)     -103 B  (-0.0%)
a8c-for-agencies-client                  -275 B  (-0.0%)     -103 B  (-0.0%)
a8c-for-agencies-purchases               -274 B  (-0.0%)     -102 B  (-0.0%)
a8c-for-agencies-partner-directory       -239 B  (-0.0%)      -74 B  (-0.0%)
a8c-for-agencies-team                    -224 B  (-0.0%)      -68 B  (-0.0%)
a8c-for-agencies-migrations              -209 B  (-0.0%)      -76 B  (-0.0%)
a8c-for-agencies-sites                   -137 B  (-0.0%)      -38 B  (-0.0%)
a8c-for-agencies-settings                -137 B  (-0.1%)      -38 B  (-0.1%)
a8c-for-agencies-plugins                 -137 B  (-0.0%)      -38 B  (-0.0%)
a8c-for-agencies-agency-tier             -137 B  (-0.1%)      -38 B  (-0.1%)
a8c-for-agencies                         -137 B  (-0.1%)      -38 B  (-0.1%)
scan                                      -77 B  (-0.0%)      -28 B  (-0.0%)
jetpack-social                            -77 B  (-0.0%)      -30 B  (-0.0%)
jetpack-search                            -77 B  (-0.0%)      -29 B  (-0.0%)
jetpack-cloud-agency-dashboard            -77 B  (-0.0%)      -30 B  (-0.0%)
backup                                    -77 B  (-0.0%)      -31 B  (-0.0%)
a8c-for-agencies-signup                   -77 B  (-0.0%)      -28 B  (-0.0%)
a8c-for-agencies-landing                  -77 B  (-0.0%)      -30 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin force-pushed the refactor/a4a/referrals/manual-referrals-cleanup branch from 23ec18e to b85f77e Compare March 19, 2025 09:58
@jkguidaven jkguidaven force-pushed the remove/a4a/temporary-core-style-prop branch from fa5ee8e to 5e04a57 Compare March 19, 2025 11:15
Base automatically changed from remove/a4a/temporary-core-style-prop to trunk March 19, 2025 12:13
@yashwin yashwin force-pushed the refactor/a4a/referrals/manual-referrals-cleanup branch from b85f77e to d6d85f0 Compare March 19, 2025 12:55
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug refactor/a4a/referrals/manual-referrals-cleanup on your sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants