-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A4A: Show WooCommerce product link on all Woo extensions product lightboxes. #101592
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
@@ -0,0 +1,63 @@ | |||
const WOOCOMMERCE_PRODUCT_SLUG_MAP = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will likely move this to the backend to create a centralized and scalable solution once we begin supporting over 1,000 third-party extensions.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~683 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm @jkguidaven. Not urgent, is it possible to use ↗ instead of the icon you have?
Thanks. This is done. |
This PR modifies the product lightboxes for all Woo products to add a product link in the footer.
Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1937
Proposed Changes
Why are these changes being made?
Testing Instructions
/marketplace/products
page.Pre-merge Checklist