Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A4A: Show WooCommerce product link on all Woo extensions product lightboxes. #101592

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

jkguidaven
Copy link
Contributor

@jkguidaven jkguidaven commented Mar 19, 2025

This PR modifies the product lightboxes for all Woo products to add a product link in the footer.

Screenshot 2025-03-19 at 10 40 51 PM

Closes https://github.com/Automattic/automattic-for-agencies-dev/issues/1937

Proposed Changes

  • Update the product lightbox to display the product link in the footer for all Woo extensions, as each extension has its own product link.

Why are these changes being made?

  • This is part of the Woo 3rd-party extension phase 2 project.

Testing Instructions

  • Use the A4A live link to navigate to the /marketplace/products page.
  • Select the 'Woo' category.
  • Test all products by clicking 'view details' and verify that all links are working.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@jkguidaven jkguidaven requested review from jeffgolenski, madebynoam and a team March 19, 2025 14:13
@jkguidaven jkguidaven self-assigned this Mar 19, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 19, 2025
@jkguidaven jkguidaven marked this pull request as ready for review March 19, 2025 14:13
@jkguidaven jkguidaven changed the title A4A: Show WooCommerce product link on all Woo extensions product lightbox. A4A: Show WooCommerce product link on all Woo extensions product lightboxes. Mar 19, 2025
@@ -0,0 +1,63 @@
const WOOCOMMERCE_PRODUCT_SLUG_MAP = {
Copy link
Contributor Author

@jkguidaven jkguidaven Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will likely move this to the backend to create a centralized and scalable solution once we begin supporting over 1,000 third-party extensions.

@matticbot
Copy link
Contributor

matticbot commented Mar 19, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~683 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
a8c-for-agencies-overview         +2911 B  (+0.2%)     +683 B  (+0.2%)
a8c-for-agencies-marketplace      +2911 B  (+0.3%)     +683 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link

@madebynoam madebynoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm @jkguidaven. Not urgent, is it possible to use ↗ instead of the icon you have?

@jkguidaven
Copy link
Contributor Author

Lgtm @jkguidaven. Not urgent, is it possible to use ↗ instead of the icon you have?

Thanks. This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants