-
Notifications
You must be signed in to change notification settings - Fork 2k
Update/dataviews package #103247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/dataviews package #103247
Conversation
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Hey @oandregal do I need to bump version of From what I understand from the FG post, that should be done in a separate PR, right? Imo, since this version doesn't bring any code updates. should we skip the automattic/dataviews release? |
@BogdanUngureanu thanks for taking care of this! I'm at the end of my day, and I'd like to review this one before merging (make sure the commit hashes are proper, etc.) with a fresh brain, as it's the first that is done by someone else :) Thank you so much 🙏 I see we're in a similar timezone, so do you mind if I review this first thing in my morning, and we proceed with merging then?
Yeah, no need to create a new |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Also! This PR is not merged via the UI, it needs to be done via the CLI (sync doc). |
Thanks @oandregal, no rush! :)
yep, I noticed that, thanks for the reminder. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the process myself and checked that the two commits coming from Gutenberg have the same hashes that in this PR: b0e92f5 and f12ffd3. The subtree split docs promised this, but it's the only tool that did, so I thought I'd double-check before proceeding.
If you'd bear with me, I'd like to do a little experiment: I'm going to mark this PR as "request changes". Please, proceed with merging via the CLI when you're ready.
I'd like to understand if there's anything that would prevent these PRs from being merged via UI but let them be merged via CLI. If you're able to push, like I think you would, I'd like to prepare a follow-up PR to add a check in TeamCity that just fails for PRs that update the CHANGELOG.md
(we only update this for PRs that sync from upstream).
Prepared a PR for this at #103296 |
This version doesn't contain any changes since the last release. I'm bumping it just to be on the latest version.
Proposed Changes
Why are these changes being made?
Testing Instructions
Pre-merge Checklist