Skip to content

Update/dataviews package #103247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2025
Merged

Update/dataviews package #103247

merged 4 commits into from
May 9, 2025

Conversation

BogdanUngureanu
Copy link
Contributor

@BogdanUngureanu BogdanUngureanu commented May 8, 2025

This version doesn't contain any changes since the last release. I'm bumping it just to be on the latest version.

Proposed Changes

  • Update the dataviews package with upstream changes.

Why are these changes being made?

  • Keeping in sync with upstream

Testing Instructions

  • There are no upstream changes since the last version

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

gutenbergplugin and others added 3 commits May 7, 2025 16:44
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
 - @wordpress/[email protected]
@BogdanUngureanu BogdanUngureanu requested a review from oandregal May 8, 2025 16:18
@BogdanUngureanu BogdanUngureanu requested review from youknowriad and a team as code owners May 8, 2025 16:18
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2025
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@BogdanUngureanu
Copy link
Contributor Author

BogdanUngureanu commented May 8, 2025

Hey @oandregal do I need to bump version of automattic/dataviews package in this PR or do I need to create a separate PR for it?

From what I understand from the FG post, that should be done in a separate PR, right?

Imo, since this version doesn't bring any code updates. should we skip the automattic/dataviews release?

@oandregal
Copy link
Contributor

@BogdanUngureanu thanks for taking care of this!

I'm at the end of my day, and I'd like to review this one before merging (make sure the commit hashes are proper, etc.) with a fresh brain, as it's the first that is done by someone else :) Thank you so much 🙏

I see we're in a similar timezone, so do you mind if I review this first thing in my morning, and we proceed with merging then?

From what I understand from the FG post, that should be done in a separate PR, right?

Yeah, no need to create a new @automattic/dataviews version — that's only done when we are about to release the npm package and that's a separate process.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/dataviews-package on your sandbox.

@oandregal
Copy link
Contributor

oandregal commented May 8, 2025

Also! This PR is not merged via the UI, it needs to be done via the CLI (sync doc).

@BogdanUngureanu
Copy link
Contributor Author

Thanks @oandregal, no rush! :)

Also! This PR is not merged via the UI, it needs to be done via the CLI (sync doc).

yep, I noticed that, thanks for the reminder. :)

Copy link
Contributor

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the process myself and checked that the two commits coming from Gutenberg have the same hashes that in this PR: b0e92f5 and f12ffd3. The subtree split docs promised this, but it's the only tool that did, so I thought I'd double-check before proceeding.

If you'd bear with me, I'd like to do a little experiment: I'm going to mark this PR as "request changes". Please, proceed with merging via the CLI when you're ready.

I'd like to understand if there's anything that would prevent these PRs from being merged via UI but let them be merged via CLI. If you're able to push, like I think you would, I'd like to prepare a follow-up PR to add a check in TeamCity that just fails for PRs that update the CHANGELOG.md (we only update this for PRs that sync from upstream).

@BogdanUngureanu BogdanUngureanu merged commit c08b3e9 into trunk May 9, 2025
11 checks passed
@BogdanUngureanu BogdanUngureanu deleted the update/dataviews-package branch May 9, 2025 09:28
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 9, 2025
@oandregal
Copy link
Contributor

I'd like to prepare a follow-up PR to add a check in TeamCity that just fails for PRs that update the CHANGELOG.md (we only update this for PRs that sync from upstream).

Prepared a PR for this at #103296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants