-
Notifications
You must be signed in to change notification settings - Fork 2k
Hosting Dashboard v2: view transitions (part 1) #103278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~406 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really cool to see!
size="small" | ||
/> | ||
<PageLayout title={ __( 'Privacy' ) } size="small"> | ||
<VStack spacing={ 4 }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we need to add VStack
in various pages? Also have you removed the description intentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the description is not present in the designs, so I removed it.
It's necessary for there to be some content because otherwise the content will slide in (from nothing) instead of cross fade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just add a placeholder paragraph then instead of these? Also PageLayout
is a VStack wrapper and its children are wrapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what you mean. I added the VStack because billing has that too for the summary buttons. Why a paragraph? These should because summary buttons, not paragraphs.
This is so cool! I've added @Automattic/dotcom-design (apologize if I'm pinging too many folks) to check if this OK design-wise for dotcom. |
Fixes DOTCOM-13060
Please note: Firefox does not support view transitions.
Screen.Recording.2025-05-09.at.17.27.33.mov
Proposed Changes
Adds view transitions for routes:
Why are these changes being made?
Testing Instructions
Pre-merge Checklist