My Profile: Remove the Extra NavigationHeader Padding

[Copons]

Fixes DOTCOM-605

Proposed Changes

• Restore the larger-screens padding to the NavigationHeader component when navigating the My Profile section (/me) on small screens (<600px).

Before	After

Why are these changes being made?

The NavigationHeader component has a 16px padding on small screens (<600px) . While this works fine for most screens, it looks out of alignment in the My Profile section (/me).

Testing Instructions

• Open the My Profile section (/me) and resize the screen below 600px.
• Confirm the NavigationHeader component doesn't have any unnecessary padding and the title is aligned with the content.
• Check that the changes are applied consistently on all My Profile pages.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143588

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143588&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143588&env=a8c-for-agencies

[matticbot]

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

[xavier-lc]

The subtitle gets out of the box on /me/developer

PR	Prod

The selector has lost its border on /me/notifications, making it look out of place.

PR	Prod

Not related to this PR, but the Most Helpful Articles subheader does have padding on /help.

[Copons]

Thank you @xavier-lc!
I totally overlooked the Developer Features header, as I didn't expect to be a NavigationHeader too.

I've stopped overriding it, restoring its original padding, as I'm considering them intentional.
I've also aligned the Support secondary titles for good measure.

I cannot repro the missing border on the Notifications dropdown, though. 🤔
Either way, it should be unrelated, as it's an entirely different component (SectionNav), placed outside NavigationHeader.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotcom-605-navigationheader-block-styling-is-inconsistent on your sandbox.

[matt-west]

Thanks @Copons. This looks good to me.

I couldn't replicate the missing border on notifications either. It appears okay for me.