STATS-59 - Match filename for the location stats to production

[Nikschavan]

Part of STATS-59

Proposed Changes

• Match the filename for the location stats to production
• This needed to be changed since - STATS-57: Location stats CSV download #103237
• Note: This still does not fix the date in the filename as that is not a regression and this seems to be happening in production as well - STATS-53 - Fix: Allow downloading UTM stats as CSV #103161 (review)

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143577

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143577&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-143577&env=a8c-for-agencies

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug stats-59-match-filename-location-stats-csv on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~67 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-calypso-my-sites-stats-summary       +137 B  (+0.3%)      +67 B  (+0.5%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Copilot]

Pull Request Overview

This PR updates the file naming for location stats to match the production behavior by incorporating the geoMode query parameter into the filename for CSV downloads.

• Added import of GEO_MODES from the types module.
• Introduced geoMode and geoModeLabel variables based on the query parameter, with a default fallback.
• Updated the DownloadCsv component path to include geoModeLabel for 'statsCountryViews'.

Comments suppressed due to low confidence (1)

client/my-sites/stats/summary/index.jsx:397

• [nitpick] Consider extracting the computed path logic into a well-named constant to enhance readability and simplify potential future modifications.

path={ statType === 'statsCountryViews' ? `${ path }-${ geoModeLabel }` : path }

[dognose24]

Could we have a Locations module dedicated scope for this query parameter?

let pathForCsvFile = path;
if ( module === 'locations' ) {
	const geoMode = this.props.context.query.geoMode;
	const geoModeLabel =
		geoMode && Object.prototype.hasOwnProperty.call( GEO_MODES, geoMode )
			? GEO_MODES[ geoMode ]
			: 'country';
	pathForCsvFile = `${ path }-${ geoModeLabel }`;
}

[dognose24]

There will be a countryviews-country filename for the legacy Countries module, isn't it?

[Copilot]

Pull Request Overview

This PR updates the filename generation logic for location stats to match production. Key changes include:

• Importing GEO_MODES from the types module.
• Computing a geoModeLabel based on the query parameter.
• Conditionally appending geoModeLabel to the path prop in the DownloadCsv component.

Comments suppressed due to low confidence (1)

client/my-sites/stats/summary/index.jsx:400

• [nitpick] Consider extracting the conditional path assignment to a variable for improved readability and easier future modifications.

path={ statType === 'statsCountryViews' ? `${ path }-${ geoModeLabel }` : path }

[Copilot]

[nitpick] Add a comment explaining the expected values in GEO_MODES and why defaulting to 'country' is appropriate to help future maintainers understand the mapping.

Suggested change

	const geoMode = this.props.context.query.geoMode;
	const geoMode = this.props.context.query.geoMode;
	// `GEO_MODES` maps geoMode values (e.g., 'country', 'region', 'city') to their display labels.
	// Defaulting to 'country' ensures a fallback label is used when geoMode is invalid or undefined,
	// as 'country' is the most commonly used and broadly applicable geographic level.