-
Notifications
You must be signed in to change notification settings - Fork 2k
2FA Setup: Use vertical nav instead of radio buttons #103286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
2FA Setup: Use vertical nav instead of radio buttons #103286
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~55 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -137,8 +136,7 @@ class TwoStep extends Component { | |||
</HeaderCake> | |||
) } | |||
|
|||
<Card>{ this.renderTwoStepSection() }</Card> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We distribute the Card
component to avoid boxes within boxes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thanks for the updates. Looks good on my end.
I see we're still using grid icons but that is happening within the component we're using. We can follow up with a separate update to change all the icons at another point.
Part of:
Proposed Changes
Why are these changes being made?
See the main issue.
Testing Instructions
/me/security/two-step
Pre-merge Checklist