-
Notifications
You must be signed in to change notification settings - Fork 2k
Improve new invite screen #103289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Improve new invite screen #103289
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the invite screen UI to be more concise and aligned with the new design specification. The changes include updated translation strings with inline line breaks, refined styling adjustments across various invite screens, and revisions to component layouts and copy details.
- Translation strings in InviteFormHeader now include explicit line breaks.
- CSS adjustments in multiple SCSS files improve layout dimensions, spacing, and alignment.
- InviteAcceptLoggedIn now renders join details (username and email) directly and updates button variants and text.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
client/my-sites/invites/invite-form-header/index.jsx | Updated translation strings to use inline elements for logged-in invite titles. |
client/my-sites/invites/invite-accept/style.scss | Adjusted maximum width for the invite accept form. |
client/my-sites/invites/invite-accept-logged-out/style.scss | Modified vertical spacing and background styles for the logged-out invite screen. |
client/my-sites/invites/invite-accept-logged-in/style.scss | Revised typographic styles and layout for the logged-in invite screen, including updated button and card styling. |
client/my-sites/invites/invite-accept-logged-in/index.jsx | Refactored the join-as text to render username and email directly and updated button component usage. |
Comments suppressed due to low confidence (3)
client/my-sites/invites/invite-form-header/index.jsx:116
- Ensure that inserting
components within translation strings is supported across all locales and renders as intended per design.
br: <br />,
client/my-sites/invites/invite-accept-logged-out/style.scss:14
- Review spacing adjustments as switching from margin-top to padding-top along with differing media query margins could lead to layout inconsistencies across screen sizes.
padding-top: 50px;
client/my-sites/invites/invite-accept-logged-in/index.jsx:64
- Confirm that replacing the translation-based join text with a direct rendering of username and email aligns with internationalization requirements for consistent localization.
return (
@@ -48,6 +50,8 @@ body.is-section-accept-invite { | |||
padding: 0; | |||
margin: 0; | |||
max-width: 372px; | |||
background: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flyby fix: there's a barely visible background difference in the logged-out invite form (#fff vs #fdfdfd).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I noticed it too.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~94 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17456076 Some locales (Brazilian Portuguese, Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @claudiucelfilip for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for these updates. Looks good to me.
Part of #100416
Proposed Changes
Updates the layout and copy of the invite screen as per design:
Why are these changes being made?
We're updating the interface to be more concise and offer more clarity.
Testing Instructions
Pre-merge Checklist