Skip to content

Components: add Storybook as peer-dependency #103291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

simison
Copy link
Member

@simison simison commented May 9, 2025

Looked at using components package v2.3.0 in Jetpack repo, and got warnings:

projects/packages/forms
└─┬ @automattic/components 2.3.0
  └─┬ @storybook/addon-actions 8.6.12
    └── ✕ missing peer storybook@^8.6.12
Peer dependencies that should be installed:
  storybook@^8.6.12

projects/packages/jetpack-mu-wpcom
└─┬ @automattic/launchpad 1.1.0
  ├─┬ @automattic/data-stores 3.1.0
  │ └─┬ @automattic/calypso-products 1.2.1
  │   └─┬ @automattic/components 2.3.0
  │     └── ✕ missing peer storybook@^8.6.12
  └─┬ @automattic/components 2.3.0
    └── ✕ missing peer storybook@^8.6.12
Peer dependencies that should be installed:
  storybook@">=8.6.12 <9.0.0-0"

Proposed Changes

  • Add Storybook as peer-dependency

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@simison simison requested review from mirka and ciampo May 9, 2025 13:40
@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Components labels May 9, 2025
Copy link

github-actions bot commented May 9, 2025

Link to live branch is being generated...
Please wait a few minutes and refresh this page.

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@simison simison force-pushed the update/components-storybook-peer-dependency branch from 3035b46 to 2f3774e Compare May 9, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Components [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants