Hosting Dashboard: Introduce I18nProvider to make translation work correctly #103299
+68
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DOTCOM-10589
Proposed Changes
I18nProvider
under/dashboard
to setup the localereduxStore
argument in thesetupLocale
function optional, and have the function return the resolved locale.Needs to be discussed:
CalypsoI18nProvider
?i18n-calypso
?Both setupLocale and switchLocale functions are tightly coupled with
i18n-calypso
. If we don't want to usei18n-calypso
, we need to decouple the logic that fetches the locale data (enabled or disabled translation chunks) and then initial the locale data by@wordpress/i18n
on v2 dashboard.Why are these changes being made?
Testing Instructions
Pre-merge Checklist