Skip to content

DIFM: Summary page updates #103308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: trunk
Choose a base branch
from
Open

DIFM: Summary page updates #103308

wants to merge 11 commits into from

Conversation

m1r0
Copy link
Member

@m1r0 m1r0 commented May 9, 2025

Resolves #102001

Proposed Changes

This PR makes a few small style changes on the DIFM summary page. It closely followed the proposed design.

  • "Total" -> "Subtotal".
  • Align the Subtotal to the top.
  • Update the spacings.
  • Remove the asterisks and the associated text.
  • Change the position of the money-back guarantee paragraph.
  • Increase the width of the checkout button.
  • Increase the subtotal price font size on mobile.
  • Fix the borders.

Desktop:
image

Mobile:
image

Why are these changes being made?

Testing Instructions

  • Go to /setup/site-setup/difmStartingPoint?siteSlug=[yoursiteslug] and follow the flow until you get to the Summary screen.
  • Compare it with the requirements from the related task.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@m1r0 m1r0 self-assigned this May 9, 2025
@matticbot
Copy link
Contributor

matticbot commented May 9, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~25 bytes removed 📉 [gzipped])

name                                 parsed_size           gzip_size
async-load-signup-steps-page-picker        +16 B  (+0.0%)      -25 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@m1r0 m1r0 force-pushed the update/difm-summary-page branch from 54502c8 to efb6d33 Compare May 9, 2025 20:20
@m1r0 m1r0 requested a review from fditrapani May 9, 2025 20:24
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 9, 2025
@m1r0 m1r0 requested a review from a team May 9, 2025 20:24
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/difm-summary-page on your sandbox.

@m1r0
Copy link
Member Author

m1r0 commented May 9, 2025

@fditrapani, here's another one. 🙂

Btw, I'm not sure if a review is needed from your side. Let me know if you prefer to skip that for the smaller/straight-forward changes.

@m1r0
Copy link
Member Author

m1r0 commented May 9, 2025

@fditrapani, you mentioned that the blue color needs an update. Can you tell me which is the correct color to use, or send me the Figma? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DIFM page screen summary
2 participants