Remove "login/social-first" feature flag #103408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #102811.
The "login/social-first" flag has been true in production env for 2 years now.
The only place it's still set to false is the desktop config, but desktop app logins are now routed through the browser so the flag is no longer relevant in that context.
This PR only deals with removing the flag. There's some confusing logic around the use of the
isSocialFirstvariable which can be dealt with afterwards. That variable is also defined in here without reference to the feature flag, and here it's given a default value offalse.Testing Instructions
Pre-merge Checklist