-
Notifications
You must be signed in to change notification settings - Fork 2k
Blaze Pro 2FA login screen: fix layout and styling issues #103537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
adamwoodnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up!
Works for me, just one question inline.
Co-authored-by: Adam Wood <[email protected]>
|
That one-liner's testing well for me, too. Thanks for taking a look @adamwoodnz! 🙇 |
adamwoodnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ![]()
Follow up to: #102811 and #103445, thanks to @adamwoodnz for catching this!
Proposed Changes
is-white-logintreatment (they skip it in the usual login screen, but the 2FA screen was still getting the top masterbar + common styling)logged-out, factor in that the oauth2 client isn't always in the query string. On the 2FA screen, it's in state, so we need to include that in the check forisWhiteLoginWhy are these changes being made?
Testing Instructions
http://calypso.localhost:3000/log-in/Screenshots
Pre-merge Checklist