Open
Conversation
simison
added
Jetpack
[Status] Needs Review
Jetpack Cloud Live (direct link)
Automattic for Agencies Live (direct link)
Dashboard Live (dotcom) (direct link)
|
simison
force-pushed
the
add/jetpack-footer
branch
from
c1afae5 to
5352663
Compare
simison
commented
Apr 1, 2026
Comment on lines
+16
to
+19
| font-size: var(--wpds-font-size-md); | ||
| font-weight: var(--wpds-font-weight-regular); | ||
| font-family: var(--wpds-font-family-body); | ||
| line-height: var(--wpds-font-line-height-sm); |
Member
Author
There was a problem hiding this comment.
Using design tokens directly instead of <Text>, due to Text still being a bit in progress regarding how it inherits its styles. Currently CSS reset of Calypso overrides due to higher specificity.
Member
Author
|
I found out we have existing Footer here; I'll look at swapping out that one instead. |
simison
added
[Status] In Progress
and removed
[Status] Needs Review
matticbot
added
the
[Status] Needs Review
Contributor
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Replaces the unused component at client/components/jetpack/jetpack-footer/ with the simplified version introduced in this branch, and removes the duplicate at client/components/jetpack-footer/. Updates all imports (activity log, earn, podcasting, traffic) to use the canonical path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
simison
force-pushed
the
add/jetpack-footer
branch
from
14ad7a2 to
c7bdd61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of JETPACK-1504
Proposed Changes
Adds simplified footer component based on component in Jetpack:
This gets us sooner to prod in WP.com, and once we have the component in Jetpack we can share it from the package. That likely will need some other changes in the upstream component so that it can be used in Calypso, though.
Background colors vary still, but those will be sorted across all pages in a follow-up work.
Using the footer at Scan & Backup I'm also leaving for another PR due to a bit more complexity of testing those pages, so this is easier to merge sooner.
Before
(Other pages had no footer at all before this)
After
Mobile
Testing Instructions
Pre-merge Checklist